Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2356123002: Revert of Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py (Closed)

Created:
4 years, 3 months ago by tikuta
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py (patchset #6 id:100001 of https://codereview.chromium.org/2332283002/ ) Reason for revert: https://build.chromium.org/p/chromium.infra.cron/builders/ChromiumOS%20Codesearch/builds/3022 ERROR at the command-line "--args":1:144: Invalid token. is_clang=true is_component_build=true is_debug=true symbol_level=1 target_cpu="x64" target_os="chromeos" use_ozone=true use_goma=true goma_dir=/b/build/slave/cache/cipd/goma Need quote for goma_dir? Original issue's description: > Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py > > * use chromium.ensure_goma() > * modify gn args to use correct goma_dir > > This is reland of https://codereview.chromium.org/2328263002/ > > BUG=621828 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/b204faa4ed43b92a19079a9f675c7c1bcbe65128 TBR=phajdan.jr@chromium.org,dsansome@chromium.org,dsansome@google.com,emso@chromium.org,iannucci@chromium.org,shinyak@chromium.org,ukai@chromium.org,yyanagisawa@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=621828 Committed: https://chromium.googlesource.com/chromium/tools/build/+/b476a27e48e383179a1461eb6f52f484d31ec5c0

Patch Set 1 #

Messages

Total messages: 5 (2 generated)
tikuta
Created Revert of Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py
4 years, 3 months ago (2016-09-21 07:18:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356123002/1
4 years, 3 months ago (2016-09-21 07:18:58 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 07:19:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/b476a27e48e383179a14...

Powered by Google App Engine
This is Rietveld 408576698