Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: src/apinatives.js

Issue 23561007: add uncached Function::New (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/api.cc ('k') | src/execution.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 // if we need to bail out from a stack overflow. 67 // if we need to bail out from a stack overflow.
68 var cache = kApiFunctionCache; 68 var cache = kApiFunctionCache;
69 var serialNumber = %GetTemplateField(data, kApiSerialNumberOffset); 69 var serialNumber = %GetTemplateField(data, kApiSerialNumberOffset);
70 var isFunctionCached = 70 var isFunctionCached =
71 (serialNumber in cache) && (cache[serialNumber] != kUninitialized); 71 (serialNumber in cache) && (cache[serialNumber] != kUninitialized);
72 if (!isFunctionCached) { 72 if (!isFunctionCached) {
73 try { 73 try {
74 cache[serialNumber] = null; 74 cache[serialNumber] = null;
75 var fun = %CreateApiFunction(data); 75 var fun = %CreateApiFunction(data);
76 if (name) %FunctionSetName(fun, name); 76 if (name) %FunctionSetName(fun, name);
77 cache[serialNumber] = fun;
78 var flags = %GetTemplateField(data, kApiFlagOffset); 77 var flags = %GetTemplateField(data, kApiFlagOffset);
78 var doNotCache = flags & (1 << kDoNotCacheBit);
79 if (!doNotCache) cache[serialNumber] = fun;
79 if (flags & (1 << kRemovePrototypeBit)) { 80 if (flags & (1 << kRemovePrototypeBit)) {
80 %FunctionRemovePrototype(fun); 81 %FunctionRemovePrototype(fun);
81 } else { 82 } else {
82 var prototype = %GetTemplateField(data, kApiPrototypeTemplateOffset); 83 var prototype = %GetTemplateField(data, kApiPrototypeTemplateOffset);
83 // Note: Do not directly use an object template as a condition, our 84 // Note: Do not directly use an object template as a condition, our
84 // internal ToBoolean doesn't handle that! 85 // internal ToBoolean doesn't handle that!
85 fun.prototype = typeof prototype === 'undefined' ? 86 fun.prototype = typeof prototype === 'undefined' ?
86 {} : Instantiate(prototype); 87 {} : Instantiate(prototype);
87 if (flags & (1 << kReadOnlyPrototypeBit)) { 88 if (flags & (1 << kReadOnlyPrototypeBit)) {
88 %FunctionSetReadOnlyPrototype(fun); 89 %FunctionSetReadOnlyPrototype(fun);
89 } 90 }
90 %SetProperty(fun.prototype, "constructor", fun, DONT_ENUM); 91 %SetProperty(fun.prototype, "constructor", fun, DONT_ENUM);
91 var parent = %GetTemplateField(data, kApiParentTemplateOffset); 92 var parent = %GetTemplateField(data, kApiParentTemplateOffset);
92 // Note: Do not directly use a function template as a condition, our 93 // Note: Do not directly use a function template as a condition, our
93 // internal ToBoolean doesn't handle that! 94 // internal ToBoolean doesn't handle that!
94 if (!(typeof parent === 'undefined')) { 95 if (!(typeof parent === 'undefined')) {
95 var parent_fun = Instantiate(parent); 96 var parent_fun = Instantiate(parent);
96 %SetPrototype(fun.prototype, parent_fun.prototype); 97 %SetPrototype(fun.prototype, parent_fun.prototype);
97 } 98 }
98 } 99 }
99 ConfigureTemplateInstance(fun, data); 100 ConfigureTemplateInstance(fun, data);
101 if (doNotCache) return fun;
100 } catch (e) { 102 } catch (e) {
101 cache[serialNumber] = kUninitialized; 103 cache[serialNumber] = kUninitialized;
102 throw e; 104 throw e;
103 } 105 }
104 } 106 }
105 return cache[serialNumber]; 107 return cache[serialNumber];
106 } 108 }
107 109
108 110
109 function ConfigureTemplateInstance(obj, data) { 111 function ConfigureTemplateInstance(obj, data) {
(...skipping 20 matching lines...) Expand all
130 obj, name, getter, setter, attribute, access_control); 132 obj, name, getter, setter, attribute, access_control);
131 } else { 133 } else {
132 throw "Bad properties array"; 134 throw "Bad properties array";
133 } 135 }
134 i += length + 1; 136 i += length + 1;
135 } 137 }
136 } finally { 138 } finally {
137 if (requires_access_checks) %EnableAccessChecks(obj); 139 if (requires_access_checks) %EnableAccessChecks(obj);
138 } 140 }
139 } 141 }
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/execution.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698