Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1723)

Unified Diff: chrome/browser/plugins/plugin_info_message_filter_unittest.cc

Issue 2356053002: [HBD] Only use Plugin Content Settings for Flash. (Closed)
Patch Set: address xhwang comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/plugins/plugin_info_message_filter_unittest.cc
diff --git a/chrome/browser/plugins/plugin_info_message_filter_unittest.cc b/chrome/browser/plugins/plugin_info_message_filter_unittest.cc
index 4426752c5dde44dc93099aec27c33ef83934e9a2..1fa4a104afccbaac4ae614a911a14cfa97946335 100644
--- a/chrome/browser/plugins/plugin_info_message_filter_unittest.cc
+++ b/chrome/browser/plugins/plugin_info_message_filter_unittest.cc
@@ -22,6 +22,7 @@
#include "content/public/browser/plugin_service.h"
#include "content/public/browser/plugin_service_filter.h"
#include "content/public/browser/render_process_host.h"
+#include "content/public/common/content_constants.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -144,9 +145,15 @@ class PluginInfoMessageFilterTest : public ::testing::Test {
CONTENT_SETTING_BLOCK : CONTENT_SETTING_DEFAULT;
bool is_default = !expected_is_default;
bool is_managed = !expected_is_managed;
- PluginUtils::GetPluginContentSetting(
- host_content_settings_map_, content::WebPluginInfo(), url, url, plugin,
- &setting, &is_default, &is_managed);
+
+ // Pass in a fake Flash plugin info.
+ content::WebPluginInfo plugin_info(
+ base::ASCIIToUTF16(content::kFlashPluginName), base::FilePath(),
+ base::ASCIIToUTF16("1"), base::ASCIIToUTF16("Fake Flash"));
+
+ PluginUtils::GetPluginContentSetting(host_content_settings_map_,
+ plugin_info, url, url, plugin,
+ &setting, &is_default, &is_managed);
EXPECT_EQ(expected_setting, setting);
EXPECT_EQ(expected_is_default, is_default);
EXPECT_EQ(expected_is_managed, is_managed);

Powered by Google App Engine
This is Rietveld 408576698