Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9729)

Unified Diff: chrome/common/plugin_utils.cc

Issue 2356053002: [HBD] Only use Plugin Content Settings for Flash. (Closed)
Patch Set: fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/plugin_utils.cc
diff --git a/chrome/common/plugin_utils.cc b/chrome/common/plugin_utils.cc
index 63db43e7e565848f755e81cfa08bd66e5e69d6e3..3b2c14a95743ec8ef22e2d0df8b1506b6d5fe36d 100644
--- a/chrome/common/plugin_utils.cc
+++ b/chrome/common/plugin_utils.cc
@@ -5,6 +5,7 @@
#include "chrome/common/plugin_utils.h"
#include "base/strings/utf_string_conversions.h"
+#include "content/public/common/content_constants.h"
#include "content/public/common/webplugininfo.h"
#include "widevine_cdm_version.h" // In SHARED_INTERMEDIATE_DIR.
@@ -13,11 +14,8 @@
#endif
bool ShouldUseJavaScriptSettingForPlugin(const content::WebPluginInfo& plugin) {
- if (plugin.type != content::WebPluginInfo::PLUGIN_TYPE_PEPPER_IN_PROCESS &&
- plugin.type !=
- content::WebPluginInfo::PLUGIN_TYPE_PEPPER_OUT_OF_PROCESS) {
+ if (plugin.name == base::ASCIIToUTF16(content::kFlashPluginName))
raymes 2016/09/26 08:18:29 I think we should check that it's an out of proces
tommycli 2016/09/27 18:51:06 Done. Thanks for the suggestion.
return false;
- }
#if !defined(DISABLE_NACL)
// Treat Native Client invocations like JavaScript.

Powered by Google App Engine
This is Rietveld 408576698