[HBD] Only use Plugin Content Settings for Flash.

content/public/test/ppapi_test_utils.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/test/ppapi_test_utils.h"
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/macros.h"
 #include "base/path_service.h"
 #include "build/build_config.h"
+#include "content/public/common/content_constants.h"
 #include "content/public/common/content_switches.h"
 #include "ppapi/shared_impl/ppapi_constants.h"
+#include "ppapi/shared_impl/ppapi_switches.h"
 
 using CharType = base::FilePath::CharType;
 using StringType = base::FilePath::StringType;
 
 namespace ppapi {
 
 namespace {
 
 struct PluginInfo {
   PluginInfo(const StringType& library_name,
@@ skipping 55 matching lines @@
   base::FilePath::StringType plugin_library = L"ppapi_tests.dll";
 #elif defined(OS_MACOSX)
   base::FilePath::StringType plugin_library = "ppapi_tests.plugin";
 #elif defined(OS_POSIX)
   base::FilePath::StringType plugin_library = "libppapi_tests.so";
 #endif
   return RegisterPluginWithDefaultMimeType(command_line, plugin_library,
                                            extra_registration_parameters);
 }
 
-bool RegisterPowerSaverTestPlugin(base::CommandLine* command_line) {
+bool RegisterFlashTestPlugin(base::CommandLine* command_line) {

[xhwang, 2016/09/27 20:35:26]

Please add some more comments. It's very confusing as for why we are using
PowerSaver plugin to test flash.

[tommycli, 2016/09/27 20:45:38]

Done.

+  // Power Saver plugin requires Pepper testing API.
+  command_line->AppendSwitch(switches::kEnablePepperTesting);
+
   base::FilePath::StringType library_name =
       base::FilePath::FromUTF8Unsafe(ppapi::kPowerSaverTestPluginName).value();
-  return RegisterPluginWithDefaultMimeType(command_line, library_name,
-                                           FILE_PATH_LITERAL(""));
+  std::vector<PluginInfo> plugins;
+  // Register a fake Flash with 100.0 version (to avoid outdated checks).
+  base::FilePath::StringType fake_flash_parameter =
+      base::FilePath::FromUTF8Unsafe(
+          std::string("#") + content::kFlashPluginName + "#Description#100.0")
+          .value();
+  plugins.push_back(
+      PluginInfo(library_name, fake_flash_parameter,
+                 FILE_PATH_LITERAL("application/x-shockwave-flash")));
+  return RegisterPlugins(command_line, plugins);
 }
 
 bool RegisterBlinkTestPlugin(base::CommandLine* command_line) {
 #if defined(OS_WIN)
   static const CharType kPluginLibrary[] = L"blink_test_plugin.dll";
   static const CharType kDeprecatedPluginLibrary[] =
       L"blink_deprecated_test_plugin.dll";
 #elif defined(OS_MACOSX)
   static const CharType kPluginLibrary[] = "blink_test_plugin.plugin";
   static const CharType kDeprecatedPluginLibrary[] =
@@ skipping 14 matching lines @@
       FILE_PATH_LITERAL("application/x-blink-test-plugin#blinktestplugin")));
   plugins.push_back(
       PluginInfo(kDeprecatedPluginLibrary, kDeprecatedExtraParameters,
                  FILE_PATH_LITERAL("application/"
                                    "x-blink-deprecated-test-plugin#"
                                    "blinkdeprecatedtestplugin")));
   return RegisterPlugins(command_line, plugins);
 }
 
 }  // namespace ppapi