[HBD] Only use Plugin Content Settings for Flash.

chrome/browser/plugins/plugin_power_saver_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 #include <string>
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/stl_util.h"
@@ skipping 13 matching lines @@
 #include "content/public/browser/readback_types.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/ppapi_test_utils.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 #include "net/test/embedded_test_server/http_request.h"
 #include "net/test/embedded_test_server/http_response.h"
-#include "ppapi/shared_impl/ppapi_switches.h"
 #include "third_party/WebKit/public/web/WebInputEvent.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/base/window_open_disposition.h"
 #include "ui/display/display.h"
 #include "ui/display/display_switches.h"
 #include "ui/display/screen.h"
 #include "ui/gfx/codec/png_codec.h"
 #include "ui/gfx/geometry/point.h"
 
 namespace {
@@ skipping 222 matching lines @@
     InProcessBrowserTest::SetUpOnMainThread();
     ASSERT_TRUE(embedded_test_server()->Start());
 
     embedded_test_server()->ServeFilesFromDirectory(
         ui_test_utils::GetTestFilePath(
             base::FilePath(FILE_PATH_LITERAL("plugin_power_saver")),
             base::FilePath()));
   }
 
   void SetUpCommandLine(base::CommandLine* command_line) override {
-    command_line->AppendSwitch(switches::kEnablePepperTesting);
     command_line->AppendSwitch(switches::kEnablePluginPlaceholderTesting);
-    command_line->AppendSwitchASCII(
-        switches::kOverridePluginPowerSaverForTesting, "ignore-list");
-
-    ASSERT_TRUE(ppapi::RegisterPowerSaverTestPlugin(command_line));
+    ASSERT_TRUE(ppapi::RegisterFlashTestPlugin(command_line));
 
     // Allows us to use the same reference image on HiDPI/Retina displays.
     command_line->AppendSwitchASCII(switches::kForceDeviceScaleFactor, "1");
 
     // The pixel tests run more reliably in software mode.
     if (PixelTestsEnabled())
       command_line->AppendSwitch(switches::kDisableGpu);
   }
 
   void SetUpInProcessBrowserTestFixture() override {
     // Although this is redundant with the Field Trial testing configuration,
     // the official builders don't use those, so we also enable it here.
     feature_list.InitAndEnableFeature(features::kBlockSmallContent);
+
+    // Disable HTML5 By Default feature to test Plugin Power Saver specifically.
+    feature_list.InitAndDisableFeature(features::kPreferHtmlOverPlugins);
   }
 
  protected:
   void LoadHTML(const std::string& html) {
     if (PixelTestsEnabled()) {
       gfx::Rect bounds(gfx::Rect(0, 0, kBrowserWidth, kBrowserHeight));
       gfx::Rect screen_bounds =
           display::Screen::GetScreen()->GetPrimaryDisplay().bounds();
       ASSERT_GT(screen_bounds.width(), kBrowserWidth);
       ASSERT_GT(screen_bounds.height(), kBrowserHeight);
@@ skipping 104 matching lines @@
 #endif
   }
 
  private:
   base::test::ScopedFeatureList feature_list;
 };
 
 IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, EssentialPlugins) {
   LoadHTML(
       "<object id='small_same_origin' data='fake.swf' "
-      "    type='application/x-ppapi-tests' width='400' height='100'>"
+      "    type='application/x-shockwave-flash' width='400' height='100'>"
       "</object>"
       "<object id='small_same_origin_poster' data='fake.swf' "
-      "    type='application/x-ppapi-tests' width='400' height='100' "
+      "    type='application/x-shockwave-flash' width='400' height='100' "
       "    poster='click_me.png'>"
       "</object>"
       "<object id='large_cross_origin' data='http://b.com/fake.swf' "
-      "    type='application/x-ppapi-tests' width='400' height='500'>"
+      "    type='application/x-shockwave-flash' width='400' height='500'>"
       "</object>"
       "<object id='medium_16_9_cross_origin' data='http://c.com/fake.swf' "
-      "    type='application/x-ppapi-tests' width='480' height='270'>"
+      "    type='application/x-shockwave-flash' width='480' height='270'>"
       "</object>");
 
   VerifyPluginMarkedEssential(GetActiveWebContents(), "small_same_origin");
   VerifyPluginMarkedEssential(GetActiveWebContents(),
                               "small_same_origin_poster");
   VerifyPluginMarkedEssential(GetActiveWebContents(), "large_cross_origin");
   VerifyPluginMarkedEssential(GetActiveWebContents(),
                               "medium_16_9_cross_origin");
 }
 
 // Flaky on WebKit Mac dbg bots: crbug.com/599484.
 #if defined(OS_MACOSX)
 #define MAYBE_SmallCrossOrigin DISABLED_SmallCrossOrigin
 #else
 #define MAYBE_SmallCrossOrigin SmallCrossOrigin
 #endif
 IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, MAYBE_SmallCrossOrigin) {
   LoadHTML(
       "<object id='plugin' data='http://otherorigin.com/fake.swf' "
-      "    type='application/x-ppapi-tests' width='400' height='100'>"
+      "    type='application/x-shockwave-flash' width='400' height='100'>"
       "</object>"
       "<br>"
       "<object id='plugin_poster' data='http://otherorigin.com/fake.swf' "
-      "    type='application/x-ppapi-tests' width='400' height='100' "
+      "    type='application/x-shockwave-flash' width='400' height='100' "
       "    poster='click_me.png'>"
       "</object>");
 
   VerifyPluginIsThrottled(GetActiveWebContents(), "plugin");
   VerifyPluginIsPlaceholderOnly("plugin_poster");
 
   EXPECT_TRUE(
       VerifySnapshot(FILE_PATH_LITERAL("small_cross_origin_expected.png")));
 
   SimulateClickAndAwaitMarkedEssential("plugin", gfx::Point(50, 50));
   SimulateClickAndAwaitMarkedEssential("plugin_poster", gfx::Point(50, 150));
 }
 
 IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, SmallerThanPlayIcon) {
   LoadHTML(
-      "<object id='plugin_16' type='application/x-ppapi-tests' "
+      "<object id='plugin_16' type='application/x-shockwave-flash' "
       "    width='16' height='16'></object>"
-      "<object id='plugin_32' type='application/x-ppapi-tests' "
+      "<object id='plugin_32' type='application/x-shockwave-flash' "
       "    width='32' height='32'></object>"
-      "<object id='plugin_16_64' type='application/x-ppapi-tests' "
+      "<object id='plugin_16_64' type='application/x-shockwave-flash' "
       "    width='16' height='64'></object>"
-      "<object id='plugin_64_16' type='application/x-ppapi-tests' "
+      "<object id='plugin_64_16' type='application/x-shockwave-flash' "
       "    width='64' height='16'></object>");
 
   VerifyPluginIsThrottled(GetActiveWebContents(), "plugin_16");
   VerifyPluginIsThrottled(GetActiveWebContents(), "plugin_32");
   VerifyPluginIsThrottled(GetActiveWebContents(), "plugin_16_64");
   VerifyPluginIsThrottled(GetActiveWebContents(), "plugin_64_16");
 
   EXPECT_TRUE(
       VerifySnapshot(FILE_PATH_LITERAL("smaller_than_play_icon_expected.png")));
 }
 
 // Flaky on WebKit Mac dbg bots: crbug.com/599484.
 #if defined(OS_MACOSX)
 #define MAYBE_PosterTests DISABLED_PosterTests
 #else
 #define MAYBE_PosterTests PosterTests
 #endif
 IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, MAYBE_PosterTests) {
   // This test simultaneously verifies the varied supported poster syntaxes,
   // as well as verifies that the poster is rendered correctly with various
   // mismatched aspect ratios and sizes, following the same rules as VIDEO.
   LoadHTML(
-      "<object id='plugin_src' type='application/x-ppapi-tests' "
+      "<object id='plugin_src' type='application/x-shockwave-flash' "
       "    width='100' height='100' poster='click_me.png'></object>"
-      "<object id='plugin_srcset' type='application/x-ppapi-tests' "
+      "<object id='plugin_srcset' type='application/x-shockwave-flash' "
       "    width='100' height='100' "
       "    poster='click_me.png 1x, click_me.png 2x'></object>"
       "<br>"
 
-      "<object id='plugin_poster_param' type='application/x-ppapi-tests' "
+      "<object id='plugin_poster_param' type='application/x-shockwave-flash' "
       "    width='100' height='100'>"
       "  <param name='poster' value='click_me.png 1x, click_me.png 2x'>"
       "</object>"
-      "<embed id='plugin_embed_src' type='application/x-ppapi-tests' "
+      "<embed id='plugin_embed_src' type='application/x-shockwave-flash' "
       "    width='100' height='100' poster='click_me.png'></embed>"
-      "<embed id='plugin_embed_srcset' type='application/x-ppapi-tests' "
+      "<embed id='plugin_embed_srcset' type='application/x-shockwave-flash' "
       "    width='100' height='100'"
       "    poster='click_me.png 1x, click_me.png 2x'></embed>"
       "<br>"
 
-      "<object id='poster_missing' type='application/x-ppapi-tests' "
+      "<object id='poster_missing' type='application/x-shockwave-flash' "
       "    width='100' height='100' poster='missing.png'></object>"
-      "<object id='poster_too_small' type='application/x-ppapi-tests' "
+      "<object id='poster_too_small' type='application/x-shockwave-flash' "
       "    width='100' height='50' poster='click_me.png'></object>"
-      "<object id='poster_too_big' type='application/x-ppapi-tests' "
+      "<object id='poster_too_big' type='application/x-shockwave-flash' "
       "    width='100' height='150' poster='click_me.png'></object>"
       "<br>"
 
-      "<object id='poster_16' type='application/x-ppapi-tests' "
+      "<object id='poster_16' type='application/x-shockwave-flash' "
       "    width='16' height='16' poster='click_me.png'></object>"
-      "<object id='poster_32' type='application/x-ppapi-tests' "
+      "<object id='poster_32' type='application/x-shockwave-flash' "
       "    width='32' height='32' poster='click_me.png'></object>"
-      "<object id='poster_16_64' type='application/x-ppapi-tests' "
+      "<object id='poster_16_64' type='application/x-shockwave-flash' "
       "    width='16' height='64' poster='click_me.png'></object>"
-      "<object id='poster_64_16' type='application/x-ppapi-tests' "
+      "<object id='poster_64_16' type='application/x-shockwave-flash' "
       "    width='64' height='16' poster='click_me.png'></object>"
       "<br>"
 
       "<div id='container' "
       "    style='width: 400px; height: 100px; overflow: hidden;'>"
       "  <object id='poster_obscured' data='http://otherorigin.com/fake.swf' "
-      "      type='application/x-ppapi-tests' width='400' height='500' "
+      "      type='application/x-shockwave-flash' width='400' height='500' "
       "      poster='click_me.png'>"
       "  </object>"
       "</div>");
 
   VerifyPluginIsPlaceholderOnly("plugin_src");
   VerifyPluginIsPlaceholderOnly("plugin_srcset");
 
   VerifyPluginIsPlaceholderOnly("plugin_poster_param");
   VerifyPluginIsPlaceholderOnly("plugin_embed_src");
   VerifyPluginIsPlaceholderOnly("plugin_embed_srcset");
@@ skipping 13 matching lines @@
 
   // Test that posters can be unthrottled via click.
   SimulateClickAndAwaitMarkedEssential("plugin_src", gfx::Point(50, 50));
 }
 
 IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, LargePostersNotThrottled) {
   // This test verifies that small posters are throttled, large posters are not,
   // and that large posters can whitelist origins for other plugins.
   LoadHTML(
       "<object id='poster_small' data='http://a.com/fake.swf' "
-      "    type='application/x-ppapi-tests' width='50' height='50' "
+      "    type='application/x-shockwave-flash' width='50' height='50' "
       "    poster='click_me.png'></object>"
       "<object id='poster_whitelisted_origin' data='http://b.com/fake.swf' "
-      "    type='application/x-ppapi-tests' width='50' height='50' "
+      "    type='application/x-shockwave-flash' width='50' height='50' "
       "    poster='click_me.png'></object>"
       "<object id='plugin_whitelisted_origin' data='http://b.com/fake.swf' "
-      "    type='application/x-ppapi-tests' width='50' height='50'></object>"
+      "    type='application/x-shockwave-flash' width='50' height='50'>"
+      "</object>"
       "<br>"
       "<object id='poster_large' data='http://b.com/fake.swf' "
-      "    type='application/x-ppapi-tests' width='400' height='300' "
+      "    type='application/x-shockwave-flash' width='400' height='300' "
       "    poster='click_me.png'></object>");
 
   VerifyPluginIsPlaceholderOnly("poster_small");
   VerifyPluginMarkedEssential(GetActiveWebContents(),
                               "poster_whitelisted_origin");
   VerifyPluginMarkedEssential(GetActiveWebContents(),
                               "plugin_whitelisted_origin");
   VerifyPluginMarkedEssential(GetActiveWebContents(), "poster_large");
 }
 
 // Flaky on ASAN bots: crbug.com/560765.
 #if defined(ADDRESS_SANITIZER)
 #define MAYBE_OriginWhitelisting DISABLED_OriginWhitelisting
 #else
 #define MAYBE_OriginWhitelisting OriginWhitelisting
 #endif
 IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, MAYBE_OriginWhitelisting) {
   LoadHTML(
       "<object id='plugin_small' data='http://a.com/fake1.swf' "
-      "    type='application/x-ppapi-tests' width='100' height='100'></object>"
+      "    type='application/x-shockwave-flash' width='100' height='100'>"
+      "</object>"
       "<object id='plugin_small_poster' data='http://a.com/fake1.swf' "
-      "    type='application/x-ppapi-tests' width='100' height='100' "
+      "    type='application/x-shockwave-flash' width='100' height='100' "
       "    poster='click_me.png'></object>"
       "<object id='plugin_large' data='http://a.com/fake2.swf' "
-      "    type='application/x-ppapi-tests' width='400' height='500'>"
+      "    type='application/x-shockwave-flash' width='400' height='500'>"
       "</object>");
   VerifyPluginMarkedEssential(GetActiveWebContents(), "plugin_small");
   VerifyPluginMarkedEssential(GetActiveWebContents(), "plugin_small_poster");
   VerifyPluginMarkedEssential(GetActiveWebContents(), "plugin_large");
 }
 
 // Flaky on almost all platforms: crbug.com/648827.
 IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest,
                        DISABLED_LargeCrossOriginObscured) {
   LoadHTML(
       "<div id='container' "
       "    style='width: 100px; height: 400px; overflow: hidden;'>"
       "  <object id='plugin' data='http://otherorigin.com/fake.swf' "
-      "      type='application/x-ppapi-tests' width='400' height='500' "
+      "      type='application/x-shockwave-flash' width='400' height='500' "
       "      style='float: right;'>"
       "  </object>"
       "</div>");
   VerifyPluginIsThrottled(GetActiveWebContents(), "plugin");
   EXPECT_TRUE(VerifySnapshot(
       FILE_PATH_LITERAL("large_cross_origin_obscured_expected.png")));
 
   // Test that's unthrottled if it is unobscured.
   std::string script =
       "var container = window.document.getElementById('container');"
       "container.setAttribute('style', 'width: 400px; height: 400px;');";
   ASSERT_TRUE(content::ExecuteScript(GetActiveWebContents(), script));
   VerifyPluginMarkedEssential(GetActiveWebContents(), "plugin");
 }
 
 IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, ExpandingSmallPlugin) {
   LoadHTML(
       "<object id='plugin' data='http://otherorigin.com/fake.swf' "
-      "    type='application/x-ppapi-tests' width='400' height='80'></object>");
+      "    type='application/x-shockwave-flash' width='400' height='80'>"
+      "</object>");
   VerifyPluginIsThrottled(GetActiveWebContents(), "plugin");
 
   std::string script = "window.document.getElementById('plugin').height = 400;";
   ASSERT_TRUE(content::ExecuteScript(GetActiveWebContents(), script));
   VerifyPluginMarkedEssential(GetActiveWebContents(), "plugin");
 }
 
 IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, BackgroundTabPlugins) {
   content::WebContents* background_contents = LoadHTMLInBackgroundTab(
       "<object id='same_origin' data='fake.swf' "
-      "    type='application/x-ppapi-tests'></object>"
+      "    type='application/x-shockwave-flash'></object>"
       "<object id='small_cross_origin' data='http://otherorigin.com/fake1.swf' "
-      "    type='application/x-ppapi-tests' width='400' height='80'></object>");
+      "    type='application/x-shockwave-flash' width='400' height='80'>"
+      "</object>");
 
   EXPECT_FALSE(PluginLoaded(background_contents, "same_origin"));
   EXPECT_FALSE(PluginLoaded(background_contents, "small_cross_origin"));
 
   ActivateTab(background_contents);
 
   VerifyPluginMarkedEssential(background_contents, "same_origin");
   VerifyPluginIsThrottled(background_contents, "small_cross_origin");
 }
 
 IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, ZoomIndependent) {
   zoom::ZoomController::FromWebContents(GetActiveWebContents())
       ->SetZoomLevel(4.0);
   LoadHTML(
       "<object id='plugin' data='http://otherorigin.com/fake.swf' "
-      "    type='application/x-ppapi-tests' width='400' height='200'>"
+      "    type='application/x-shockwave-flash' width='400' height='200'>"
       "</object>");
   VerifyPluginIsThrottled(GetActiveWebContents(), "plugin");
 }
 
 IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, BlockTinyPlugins) {
   LoadHTML(
       "<object id='tiny_same_origin' data='fake.swf' "
-      "    type='application/x-ppapi-tests' width='3' height='3'>"
+      "    type='application/x-shockwave-flash' width='3' height='3'>"
       "</object>"
       "<object id='tiny_cross_origin_1' data='http://a.com/fake.swf' "
-      "    type='application/x-ppapi-tests' width='3' height='3'>"
+      "    type='application/x-shockwave-flash' width='3' height='3'>"
       "</object>"
       "<object id='tiny_cross_origin_2' data='http://a.com/fake.swf' "
-      "    type='application/x-ppapi-tests' width='1' height='1'>"
+      "    type='application/x-shockwave-flash' width='1' height='1'>"
       "</object>");
 
   VerifyPluginMarkedEssential(GetActiveWebContents(), "tiny_same_origin");
   VerifyPluginIsPlaceholderOnly("tiny_cross_origin_1");
   VerifyPluginIsPlaceholderOnly("tiny_cross_origin_2");
 }
 
 IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, BackgroundTabTinyPlugins) {
   content::WebContents* background_contents = LoadHTMLInBackgroundTab(
       "<object id='tiny' data='http://a.com/fake.swf' "
-      "    type='application/x-ppapi-tests' width='3' height='3'>"
+      "    type='application/x-shockwave-flash' width='3' height='3'>"
       "</object>");
   EXPECT_FALSE(PluginLoaded(background_contents, "tiny"));
 
   ActivateTab(background_contents);
   VerifyPluginIsPlaceholderOnly("tiny");
 }
 
 IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, ExpandingTinyPlugins) {
   LoadHTML(
       "<object id='expand_to_peripheral' data='http://a.com/fake.swf' "
-      "    type='application/x-ppapi-tests' width='4' height='4'></object>"
+      "    type='application/x-shockwave-flash' width='4' height='4'></object>"
       "<object id='expand_to_essential' data='http://b.com/fake.swf' "
-      "    type='application/x-ppapi-tests' width='4' height='4'></object>");
+      "    type='application/x-shockwave-flash' width='4' height='4'>"
+      "</object>");
 
   VerifyPluginIsPlaceholderOnly("expand_to_peripheral");
   VerifyPluginIsPlaceholderOnly("expand_to_essential");
 
   std::string script =
       "window.document.getElementById('expand_to_peripheral').height = 200;"
       "window.document.getElementById('expand_to_peripheral').width = 200;"
       "window.document.getElementById('expand_to_essential').height = 400;"
       "window.document.getElementById('expand_to_essential').width = 400;";
   ASSERT_TRUE(content::ExecuteScript(GetActiveWebContents(), script));
 
   VerifyPluginIsThrottled(GetActiveWebContents(), "expand_to_peripheral");
   VerifyPluginMarkedEssential(GetActiveWebContents(), "expand_to_essential");
 }
 
 // Separate test case that allows tiny plugins. This requires a separate test
 // case, because we need to initialize the renderer with a different feature
 // setting.
 class PluginPowerSaverAllowTinyBrowserTest
     : public PluginPowerSaverBrowserTest {
  public:
   void SetUpInProcessBrowserTestFixture() override {
+    PluginPowerSaverBrowserTest::SetUpInProcessBrowserTestFixture();
     feature_list.InitAndDisableFeature(features::kBlockSmallContent);
   }
 
  private:
   base::test::ScopedFeatureList feature_list;
 };
 
 IN_PROC_BROWSER_TEST_F(PluginPowerSaverAllowTinyBrowserTest,
                        EssentialTinyPlugins) {
   LoadHTML(
       "<object id='tiny_cross_origin_1' data='http://a.com/fake.swf' "
-      "    type='application/x-ppapi-tests' width='3' height='3'>"
+      "    type='application/x-shockwave-flash' width='3' height='3'>"
       "</object>"
       "<object id='tiny_cross_origin_2' data='http://a.com/fake.swf' "
-      "    type='application/x-ppapi-tests' width='1' height='1'>"
+      "    type='application/x-shockwave-flash' width='1' height='1'>"
       "</object>");
 
   VerifyPluginMarkedEssential(GetActiveWebContents(), "tiny_cross_origin_1");
   VerifyPluginMarkedEssential(GetActiveWebContents(), "tiny_cross_origin_2");
 }