Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23560013: Remove unused items in the ash tray for Windows. (Closed)

Created:
7 years, 3 months ago by cpu_(ooo_6.6-7.5)
Modified:
7 years, 2 months ago
Reviewers:
flackr, sadrul
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Remove unused items in the ash tray for Windows. Like the update nagger Like IME Like the drive item BUG=227247 TEST=see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226404

Patch Set 1 #

Patch Set 2 : change window size #

Patch Set 3 : add missing file #

Patch Set 4 : add missing file #

Patch Set 5 : rebase and cleanup #

Patch Set 6 : fix ifdefs again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M ash/system/tray/system_tray.cc View 1 2 3 4 5 1 chunk +15 lines, -16 lines 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 1 13 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
cpu_(ooo_6.6-7.5)
can you please review this soon? thanks.
7 years, 3 months ago (2013-09-20 04:48:42 UTC) #1
sadrul
LGTM
7 years, 3 months ago (2013-09-20 04:50:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/23560013/1
7 years, 3 months ago (2013-09-20 14:56:00 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-20 15:03:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/23560013/1
7 years, 3 months ago (2013-09-20 22:03:47 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) ash_unittests, browser_tests, interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=81435
7 years, 3 months ago (2013-09-21 00:38:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/23560013/1
7 years, 3 months ago (2013-09-21 18:17:07 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=81649
7 years, 3 months ago (2013-09-23 00:26:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/23560013/57002
7 years, 2 months ago (2013-09-25 19:21:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/23560013/57002
7 years, 2 months ago (2013-09-25 21:27:54 UTC) #10
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=27530
7 years, 2 months ago (2013-09-26 06:32:18 UTC) #11
flackr
LGTM
7 years, 2 months ago (2013-09-26 17:55:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/23560013/57002
7 years, 2 months ago (2013-09-26 18:00:55 UTC) #13
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=81856
7 years, 2 months ago (2013-09-26 22:10:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/23560013/57002
7 years, 2 months ago (2013-09-27 00:50:35 UTC) #15
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=82078
7 years, 2 months ago (2013-09-27 05:06:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/23560013/100001
7 years, 2 months ago (2013-10-01 01:04:43 UTC) #17
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-01 02:17:10 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/23560013/100001
7 years, 2 months ago (2013-10-01 09:33:39 UTC) #19
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=160755
7 years, 2 months ago (2013-10-01 10:16:11 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/23560013/100001
7 years, 2 months ago (2013-10-01 17:46:12 UTC) #21
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) ash_unittests, browser_tests, interactive_ui_tests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=160886
7 years, 2 months ago (2013-10-01 18:39:28 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/23560013/141001
7 years, 2 months ago (2013-10-02 02:51:28 UTC) #23
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 06:53:25 UTC) #24
Message was sent while issue was closed. 
Change committed as 226404

Powered by Google App Engine
This is Rietveld 408576698