[Sync] Restructure ModelTypeWorkerTest to match SMTP test.

[Sync] Restructure ModelTypeWorkerTest to match SMTP test.

- Move function definitions inside the class declaration.
- Move static functions to an anonymous namespace.
- Introduce kTagN, kValueN, and kHashN constants.
- Remove 14 methods that were simply forwards to calls on the processor
  or server and add direct accessors to those classes instead.

BUG=648705
Committed: https://crrev.com/260ea4c5badff5adfd768dd6d51085d78c239885
Cr-Commit-Position: refs/heads/master@{#419861}

[maxbogue, 2016-09-20 21:00:03]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 21:00:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-09-20 21:04:00]

maxbogue@chromium.org changed reviewers:
+ skym@chromium.org

[maxbogue, 2016-09-20 21:04:01]

Sky, PTAL!

[skym, 2016-09-20 21:13:50]

lgtm

https://codereview.chromium.org/2355993002/diff/1/components/sync/engine_impl...
File components/sync/engine_impl/model_type_worker_unittest.cc (right):

https://codereview.chromium.org/2355993002/diff/1/components/sync/engine_impl...
components/sync/engine_impl/model_type_worker_unittest.cc:189: DCHECK(!worker_);
Should we change all these unittest DCHECKs to CHECKs?

https://codereview.chromium.org/2355993002/diff/1/components/sync/engine_impl...
components/sync/engine_impl/model_type_worker_unittest.cc:296: 
Remove newline?

[maxbogue, 2016-09-20 21:32:44]

https://codereview.chromium.org/2355993002/diff/1/components/sync/engine_impl...
File components/sync/engine_impl/model_type_worker_unittest.cc (right):

https://codereview.chromium.org/2355993002/diff/1/components/sync/engine_impl...
components/sync/engine_impl/model_type_worker_unittest.cc:189: DCHECK(!worker_);
On 2016/09/20 21:13:49, skym wrote:
> Should we change all these unittest DCHECKs to CHECKs?

As discussed offline, I don't think it matters for tests.

https://codereview.chromium.org/2355993002/diff/1/components/sync/engine_impl...
components/sync/engine_impl/model_type_worker_unittest.cc:296: 
On 2016/09/20 21:13:49, skym wrote:
> Remove newline?

It's a section comment, like the one on 276. Applies to more than just the next
function.

[maxbogue, 2016-09-20 21:39:48]

The CQ bit was unchecked by maxbogue@chromium.org

[maxbogue, 2016-09-20 21:39:50]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-09-20 21:40:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 21:53:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-20 21:55:13]

Description was changed from

==========
[Sync] Restructure ModelTypeWorkerTest to match SMTP test.

- Move function definitions inside the class declaration.
- Move static functions to an anonymous namespace.
- Introduce kTagN, kValueN, and kHashN constants.
- Remove 14 methods that were simply forwards to calls on the processor
  or server and add direct accessors to those classes instead.

BUG=648705
==========

to

==========
[Sync] Restructure ModelTypeWorkerTest to match SMTP test.

- Move function definitions inside the class declaration.
- Move static functions to an anonymous namespace.
- Introduce kTagN, kValueN, and kHashN constants.
- Remove 14 methods that were simply forwards to calls on the processor
  or server and add direct accessors to those classes instead.

BUG=648705

Committed: https://crrev.com/260ea4c5badff5adfd768dd6d51085d78c239885
Cr-Commit-Position: refs/heads/master@{#419861}
==========

[commit-bot: I haz the power, 2016-09-20 21:55:14]

Patchset 1 (id:??) landed as
https://crrev.com/260ea4c5badff5adfd768dd6d51085d78c239885
Cr-Commit-Position: refs/heads/master@{#419861}