Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3099)

Unified Diff: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

Issue 2355963002: Avert crash in ExtensionInstalledBubbleView::GetWindowTitle triggered (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
index 217db73ae8125f2eaad8b696d63117c4ccd5412f..1c85308ee2394f728e0cd74bfc864890f50e51d7 100644
--- a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
+++ b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
@@ -171,6 +171,11 @@ void ExtensionInstalledBubbleView::CloseBubble() {
}
base::string16 ExtensionInstalledBubbleView::GetWindowTitle() const {
Devlin 2016/09/20 20:15:43 Is there any way we could detect the view is close
+ // This may be called by screen readers after the window is closed.
+ // See crbug.com/648280
+ if (!controller_)
+ return base::string16();
+
// Add the heading (for all options).
base::string16 extension_name =
base::UTF8ToUTF16(controller_->extension()->name());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698