Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2355953003: exo: Fix crash in SetCursor (Closed)

Created:
4 years, 3 months ago by denniskempin
Modified:
4 years, 3 months ago
Reviewers:
reveman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Fix crash in SetCursor SetCursor can crash in rare circumstances when no event has been processed yet, but SetCursor is called by the client. Adds line to initialize the cursor widget if it does not exist. BUG=chromium:648724 TEST=none Committed: https://crrev.com/1d09b45aabcb055e293a19064f1defe1ba2dcbd8 Cr-Commit-Position: refs/heads/master@{#419947}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/exo/pointer.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
denniskempin
PTAL David! Causes rare crashes on my device when used with direct input.
4 years, 3 months ago (2016-09-20 21:53:02 UTC) #2
reveman
lgtm
4 years, 3 months ago (2016-09-21 01:41:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355953003/1
4 years, 3 months ago (2016-09-21 01:42:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 02:07:30 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 02:09:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d09b45aabcb055e293a19064f1defe1ba2dcbd8
Cr-Commit-Position: refs/heads/master@{#419947}

Powered by Google App Engine
This is Rietveld 408576698