Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2355943002: Revert of Skia recipe: Use [depot_tools]/gsutil.py instead of [depot_tools]/third_party/gsutil/gsuti (Closed)

Created:
4 years, 3 months ago by borenet
Modified:
4 years, 3 months ago
Reviewers:
Ryan Tseng
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Skia recipe: Use [depot_tools]/gsutil.py instead of [depot_tools]/third_party/gsutil/gsutil (patchset #1 id:1 of https://codereview.chromium.org/2298293002/ ) Reason for revert: Broke all nanobench uploads, eg. https://uberchromegw.corp.google.com/i/client.skia.android/builders/Perf-Android-Clang-Nexus6p-CPU-Snapdragon810-arm64-Release-GN_Android/builds/154/steps/Upload%20perf%20results/logs/stdio Original issue's description: > Skia recipe: Use [depot_tools]/gsutil.py instead of [depot_tools]/third_party/gsutil/gsutil > > The latter is being removed in https://codereview.chromium.org/2280023003/ > Is also pinned to 3.25, whereas the former is updated more often. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298293002 > > Committed: https://skia.googlesource.com/skia/+/f15590f803596f51d0950994b2aeb623d2d1fc24 TBR=hinoka@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/0ecd91695fdc730ff0f1a56681c32ff3d7fea28f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M infra/bots/recipes/swarm_housekeeper.py View 1 chunk +2 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_housekeeper.expected/Housekeeper-PerCommit.json View 2 chunks +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_housekeeper.expected/Housekeeper-PerCommit-Trybot.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_trigger.py View 1 chunk +2 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_trigger.expected/Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Trybot.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (5 generated)
borenet
Created Revert of Skia recipe: Use [depot_tools]/gsutil.py instead of [depot_tools]/third_party/gsutil/gsutil
4 years, 3 months ago (2016-09-20 19:33:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355943002/1
4 years, 3 months ago (2016-09-20 19:33:51 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 19:34:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0ecd91695fdc730ff0f1a56681c32ff3d7fea28f

Powered by Google App Engine
This is Rietveld 408576698