Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2355933002: [DrMemory] Remove chrome_elf_unittests gtest exclusions. (Closed)

Created:
4 years, 3 months ago by penny
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang, benwells
CC:
chromium-reviews, pennymac+watch_chromium.org, caitkp+watch_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DrMemory] Remove chrome_elf_unittests gtest exclusions. - ELFImportsTest.ChromeElfSanityCheck should not be disabled. If there are failures during this test, they need to be addressed not ignored. - BlacklistTest.* no longer exist, so don't need to be excluded. R=thestig@chromium.org,benwells@chromium.org TEST=Ensure DrMemory bot runs clean. BUG=621460, 628462 Committed: https://crrev.com/962fe81d78f08b5776f9fa658a301c2e2cf43bf4 Cr-Commit-Position: refs/heads/master@{#420174}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
D tools/valgrind/gtest_exclude/chrome_elf_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Lei Zhang
lgtm I think you should just land it. If it breaks the bots, we can ...
4 years, 3 months ago (2016-09-21 18:20:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355933002/1
4 years, 3 months ago (2016-09-21 21:04:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 21:59:34 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/962fe81d78f08b5776f9fa658a301c2e2cf43bf4 Cr-Commit-Position: refs/heads/master@{#420174}
4 years, 3 months ago (2016-09-21 22:03:04 UTC) #8
Lei Zhang
4 years, 2 months ago (2016-09-28 00:51:02 UTC) #10
Message was sent while issue was closed.
BlacklistTest still seems to exist though. It's failing here:
https://build.chromium.org/p/chromium.memory.full/builders/Windows%20Unit%20%...

Powered by Google App Engine
This is Rietveld 408576698