Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2355913002: Add a new shared page state in pixel_tests.py (Closed)

Created:
4 years, 3 months ago by xidachen
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a new shared page state in pixel_tests.py In a previous CL:https://codereview.chromium.org/2328463004/, there was a pixel test that is added which test WebGL's commit() function. What was missing in that CL is that the test requires an additional browser arg: --enable-experimental-canvas-features. Without this flag, it is causing timeout exception. This CL adds a new shared page state with that flag, which should make the bots correctly run this test and generate reference images. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/3d94ca5729af33523e919f7af0cb2209fb339930 Cr-Commit-Position: refs/heads/master@{#420033}

Patch Set 1 #

Patch Set 2 : add parameter in trace test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M content/test/gpu/gpu_tests/trace_test.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/trace_test_expectations.py View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/page_sets/pixel_tests.py View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
xidachen
PTAL
4 years, 3 months ago (2016-09-20 18:12:47 UTC) #3
Ken Russell (switch to Gerrit)
LGTM This is surely the reason that the suppression in src/content/test/gpu/gpu_tests/trace_test_expectations.py also had to be ...
4 years, 3 months ago (2016-09-21 00:25:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355913002/20001
4 years, 3 months ago (2016-09-21 12:39:22 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-21 13:18:53 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 13:20:36 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3d94ca5729af33523e919f7af0cb2209fb339930
Cr-Commit-Position: refs/heads/master@{#420033}

Powered by Google App Engine
This is Rietveld 408576698