Stop closing filled paths in GrShape

Stop closing filled paths in GrShape

This can force a copy of the path data and isn't really being taken advantage of. It complicates a forthcoming change to key small paths based on their data rather than gen id.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355833002

Committed: https://skia.googlesource.com/skia/+/ad001fdc77b2dfe32c1723cb58636728dfb776d8
Committed: https://skia.googlesource.com/skia/+/8eb43e5f63306a22570b977bbb69e4ec78432d24

[bsalomon, 2016-09-20 14:06:54]

Description was changed from

==========
Stop closing filled paths in GrShape.

This can force a copy of the path data and isn't really being taken advantage
of. It complicates a forthcoming change to key small paths based on their data
rather than gen id.
==========

to

==========
Stop closing filled paths in GrShape.

This can force a copy of the path data and isn't really being taken advantage
of. It complicates a forthcoming change to key small paths based on their data
rather than gen id.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355833002
==========

[bsalomon, 2016-09-20 14:07:19]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2016-09-20 14:07:29]

Description was changed from

==========
Stop closing filled paths in GrShape.

This can force a copy of the path data and isn't really being taken advantage
of. It complicates a forthcoming change to key small paths based on their data
rather than gen id.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355833002
==========

to

==========
Stop closing filled paths in GrShape

This can force a copy of the path data and isn't really being taken advantage
of. It complicates a forthcoming change to key small paths based on their data
rather than gen id.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355833002
==========

[robertphillips, 2016-09-20 16:49:39]

lgtm

[bsalomon, 2016-09-20 17:12:11]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-09-20 17:12:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 19:44:38]

Description was changed from

==========
Stop closing filled paths in GrShape

This can force a copy of the path data and isn't really being taken advantage
of. It complicates a forthcoming change to key small paths based on their data
rather than gen id.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355833002
==========

to

==========
Stop closing filled paths in GrShape

This can force a copy of the path data and isn't really being taken advantage
of. It complicates a forthcoming change to key small paths based on their data
rather than gen id.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355833002

Committed:
https://skia.googlesource.com/skia/+/ad001fdc77b2dfe32c1723cb58636728dfb776d8
==========

[commit-bot: I haz the power, 2016-09-20 19:44:39]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ad001fdc77b2dfe32c1723cb58636728dfb776d8

[f(malita), 2016-09-20 20:58:47]

On 2016/09/20 19:44:39, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
> https://skia.googlesource.com/skia/+/ad001fdc77b2dfe32c1723cb58636728dfb776d8

c:\b\work\skia\src\gpu\grmesh.h:76: fatal error: "assert(indexCount)"

Caught exception 2147483651 EXCEPTION_BREAKPOINT, was running:
	msaa16 svg  cartman.svg
Likely culprit:
	msaa16 svg  cartman.svg
step returned non-zero exit code: -2147483645

Eric reverted https://codereview.chromium.org/2353503005/, but I think the
assert is actually triggered by this CL.  Just a heads up, waiting on the
bots...

[f(malita), 2016-09-20 21:04:47]

On 2016/09/20 20:58:47, f(malita) wrote:
> On 2016/09/20 19:44:39, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
https://skia.googlesource.com/skia/+/ad001fdc77b2dfe32c1723cb58636728dfb776d8
> 
> c:\b\work\skia\src\gpu\grmesh.h:76: fatal error: "assert(indexCount)"
> 
> Caught exception 2147483651 EXCEPTION_BREAKPOINT, was running:
> 	msaa16 svg  cartman.svg
> Likely culprit:
> 	msaa16 svg  cartman.svg
> step returned non-zero exit code: -2147483645
> 
> Eric reverted https://codereview.chromium.org/2353503005/, but I think the
> assert is actually triggered by this CL.  Just a heads up, waiting on the
> bots...

Yup, still red.  I've also manually checked that the assert is tripped with this
CL.

Going to revert.

[fmalita_google_do_not_use, 2016-09-20 21:06:44]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2357713002/ by fmalita@google.com.

The reason for reverting is: Triggers msaa16 asserts:
https://build.chromium.org/p/client.skia/builders/Test-Win10-MSVC-ShuttleA-GP...

c:\b\work\skia\src\gpu\grmesh.h:76: fatal error: "assert(indexCount)"

Caught exception 2147483651 EXCEPTION_BREAKPOINT, was running:
	msaa16 svg  cartman.svg
Likely culprit:
	msaa16 svg  cartman.svg.

[bsalomon, 2016-09-21 14:06:39]

Description was changed from

==========
Stop closing filled paths in GrShape

This can force a copy of the path data and isn't really being taken advantage
of. It complicates a forthcoming change to key small paths based on their data
rather than gen id.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355833002

Committed:
https://skia.googlesource.com/skia/+/ad001fdc77b2dfe32c1723cb58636728dfb776d8
==========

to

==========
Stop closing filled paths in GrShape

This can force a copy of the path data and isn't really being taken advantage
of. It complicates a forthcoming change to key small paths based on their data
rather than gen id.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355833002

Committed:
https://skia.googlesource.com/skia/+/ad001fdc77b2dfe32c1723cb58636728dfb776d8
==========

[bsalomon, 2016-09-21 14:08:13]

The MSAAPathRenderer was relying on the closing behavior of GrShape. I modified
it to use a force-closing iterator so it will see a final lineTo for unclosed
contours. This is better overall as GrShape was only closing the last contour.

[bsalomon, 2016-09-21 14:08:18]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-09-21 14:08:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2355833002/#ps20001
(title: "Fix MSAA path renderer to use closing iterator")

[commit-bot: I haz the power, 2016-09-21 14:08:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 14:47:35]

Description was changed from

==========
Stop closing filled paths in GrShape

This can force a copy of the path data and isn't really being taken advantage
of. It complicates a forthcoming change to key small paths based on their data
rather than gen id.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355833002

Committed:
https://skia.googlesource.com/skia/+/ad001fdc77b2dfe32c1723cb58636728dfb776d8
==========

to

==========
Stop closing filled paths in GrShape

This can force a copy of the path data and isn't really being taken advantage
of. It complicates a forthcoming change to key small paths based on their data
rather than gen id.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355833002

Committed:
https://skia.googlesource.com/skia/+/ad001fdc77b2dfe32c1723cb58636728dfb776d8
Committed:
https://skia.googlesource.com/skia/+/8eb43e5f63306a22570b977bbb69e4ec78432d24
==========

[commit-bot: I haz the power, 2016-09-21 14:47:36]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/8eb43e5f63306a22570b977bbb69e4ec78432d24