Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 2355793002: Merge 2840: Fix when orthogonal writing mode roots have floating siblings (Closed)

Created:
4 years, 3 months ago by kojii
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Merge 2840: Fix when orthogonal writing mode roots have floating siblings When orthogonal writing mode roots have floating siblings, its containing block may still have old or even deleted LayoutObjects. This occurs when LayoutMultiColumnFlowThread::populate(), LayoutBoxModelObject::moveChildrenTo() with !fullRemoveInsert, or more, for the optimization purposes. This patch clears such objects to be re-created when the containing block is laid out. BUG=604095, 633409, 646178 Review-Url: https://codereview.chromium.org/2025543002 Cr-Commit-Position: refs/heads/master@{#419376} (cherry picked from commit 5c43382692e6b687373576984181e52c30ccd142) Committed: https://chromium.googlesource.com/chromium/src/+/f0a010e317a1043e7faf7160f6d2afb760d6f1f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/writing-mode/orthogonal-writing-modes-floats-crash.html View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/writing-mode/orthogonal-writing-modes-floats-crash-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +21 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kojii
4 years, 3 months ago (2016-09-20 13:15:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f0a010e317a1043e7faf7160f6d2afb760d6f1f5.

Powered by Google App Engine
This is Rietveld 408576698