Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2355723002: Remove obsolete RECORD_WITH_SK_NULL_CANVAS recording mode. (Closed)

Created:
4 years, 3 months ago by wkorman
Modified:
4 years, 2 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete RECORD_WITH_SK_NULL_CANVAS recording mode. BUG=648336 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/2e41c6f8e524772b3b7a8e31313c047f8d53947a Cr-Commit-Position: refs/heads/master@{#421131}

Patch Set 1 #

Patch Set 2 : Remove refs to sk null canvas from measurement. #

Patch Set 3 : Sync to head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M cc/debug/rasterize_and_record_benchmark.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/playback/recording_source.h View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/perf/measurements/rasterize_and_record_micro.py View 1 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
wkorman
4 years, 3 months ago (2016-09-20 00:45:05 UTC) #3
wkorman
I suppose this change has to go in tandem with removing references in: https://cs.chromium.org/chromium/src/tools/perf/measurements/rasterize_and_record_micro.py?dr&q=null_canvas+file:%5Esrc/tools/perf/&sq=package:chromium&l=88 Is ...
4 years, 3 months ago (2016-09-20 00:47:02 UTC) #4
wkorman
+aiolos for OWNERS on tools/perf.
4 years, 3 months ago (2016-09-20 00:56:43 UTC) #6
vmpstr
cc lgtm
4 years, 3 months ago (2016-09-20 01:08:04 UTC) #7
Stephen Chennney
lgtm from me as the person who originally added it. Thanks for getting this cleaned ...
4 years, 3 months ago (2016-09-20 13:50:07 UTC) #8
aiolos (Not reviewing)
lgtm
4 years, 2 months ago (2016-09-22 17:44:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355723002/40001
4 years, 2 months ago (2016-09-27 05:49:52 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-27 06:47:39 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 06:49:10 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2e41c6f8e524772b3b7a8e31313c047f8d53947a
Cr-Commit-Position: refs/heads/master@{#421131}

Powered by Google App Engine
This is Rietveld 408576698