Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2355713002: Fix a bug in `gn analyze` related to build-only changes. (Closed)

Created:
4 years, 3 months ago by Dirk Pranke
Modified:
4 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bug in `gn analyze` related to build-only changes. `gn analyze` would incorrectly claim that no compile was necessary if given a list of files that included build file changes but not any source file changes. R=brettw@chromium.org BUG=648448 Committed: https://crrev.com/253b1190a67b4ccac5c8b2583e6b19c6a1c5e3f9 Cr-Commit-Position: refs/heads/master@{#419662}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -11 lines) Patch
M tools/gn/analyzer.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M tools/gn/analyzer_unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Dirk Pranke
4 years, 3 months ago (2016-09-19 23:22:52 UTC) #2
brettw
lgtm
4 years, 3 months ago (2016-09-19 23:32:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355713002/1
4 years, 3 months ago (2016-09-20 02:48:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 02:53:14 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 02:55:40 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/253b1190a67b4ccac5c8b2583e6b19c6a1c5e3f9
Cr-Commit-Position: refs/heads/master@{#419662}

Powered by Google App Engine
This is Rietveld 408576698