Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issue 2355703004: profile switcher: allow numpad enter for button activations (Closed)

Created:
4 years, 3 months ago by Elly Fong-Jones
Modified:
4 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

profile switcher: allow numpad enter for button activations BUG=646331 Committed: https://crrev.com/1aaa76992d247f75a8298f27989dfd43ae9eda26 Cr-Commit-Position: refs/heads/master@{#420030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Elly Fong-Jones
avi: ptal? :)
4 years, 3 months ago (2016-09-20 17:15:08 UTC) #3
Avi (use Gerrit)
lgtm
4 years, 3 months ago (2016-09-20 17:16:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355703004/1
4 years, 3 months ago (2016-09-20 18:24:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/299602)
4 years, 3 months ago (2016-09-20 19:50:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355703004/1
4 years, 3 months ago (2016-09-21 11:40:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 12:26:28 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 12:28:17 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1aaa76992d247f75a8298f27989dfd43ae9eda26
Cr-Commit-Position: refs/heads/master@{#420030}

Powered by Google App Engine
This is Rietveld 408576698