Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2355703002: Remove all OnBeforeNetworkAccessed code above NetworkTransaction. (Closed)

Created:
4 years, 3 months ago by mmenke
Modified:
4 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, jam, Randy Smith (Not in Mondays), darin-cc_chromium.org, loading-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all OnBeforeNetworkAccessed code above NetworkTransaction. It's still needed at the NetworkTransaction layer for devtools simulating being offline, though can probably get rid of that, if we don't mind the offline check jumping ahead of the new throttler. Also remove some OnBeforeNetworkAccessed code left over in ResourceLoader. BUG=479994 Committed: https://crrev.com/02b1f1dc9bbc5fe46f1159e00e207b4aa1733ffd Cr-Commit-Position: refs/heads/master@{#420098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M content/browser/loader/resource_loader.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/resource_loader.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/url_request/url_request.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/url_request/url_request.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M net/url_request/url_request_http_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_request_http_job.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/url_request/url_request_job.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/url_request/url_request_job.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
mmenke
Noticed we can remove yet more of this stuff.
4 years, 3 months ago (2016-09-20 14:36:08 UTC) #7
Randy Smith (Not in Mondays)
LGTM. What used to call into this/result in a deferred network start?
4 years, 3 months ago (2016-09-21 16:17:13 UTC) #8
mmenke
On 2016/09/21 16:17:13, Randy Smith - Not in Mondays wrote: > LGTM. > > What ...
4 years, 3 months ago (2016-09-21 16:34:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355703002/1
4 years, 3 months ago (2016-09-21 16:35:39 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 17:50:21 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 17:52:32 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02b1f1dc9bbc5fe46f1159e00e207b4aa1733ffd
Cr-Commit-Position: refs/heads/master@{#420098}

Powered by Google App Engine
This is Rietveld 408576698