Run commands in the mini_installer test framework from the framework's directory.

Run commands in the mini_installer test framework from the framework's directory.

The framework ran commands from the current working directory. Make it run commands from the framework's directory.

NOTRY=True 
BUG=264859
TEST=
1) Uninstall Chrome (if it's installed.)
2) Build Chrome with Release mode and make sure that mini_installer.exe is created.
3) Go to src\chrome\test\mini_installer
4) Run "python test_installer.py config\config.config --build-dir=<build-dir> --target=Release" where <build-dir> is the path to main build directory (the parent of the Release directory). The test should pass.
5) Go to src\chrome\test
6) Run "python mini_installer\test_installer.py mini_installer\config\config.config --build-dir=<build-dir> --target=Release". The test should pass.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221361

[sukolsak, 2013-09-04 18:23:26]

Could you please review this?

[gab, 2013-09-04 22:14:40]

lgtm unless mathp has a better solution than os.path.dirname(__file__)

[robertshield, 2013-09-04 22:16:29]

lgtm

https://codereview.chromium.org/23557009/diff/1/chrome/test/mini_installer/te...
File chrome/test/mini_installer/test_installer.py (right):

https://codereview.chromium.org/23557009/diff/1/chrome/test/mini_installer/te...
chrome/test/mini_installer/test_installer.py:108: def _RunCommand(self,
command):
please add a brief method comment that mentions that the command is run from the
current file's dir

[sukolsak, 2013-09-04 22:53:49]

Thanks.

https://codereview.chromium.org/23557009/diff/1/chrome/test/mini_installer/te...
File chrome/test/mini_installer/test_installer.py (right):

https://codereview.chromium.org/23557009/diff/1/chrome/test/mini_installer/te...
chrome/test/mini_installer/test_installer.py:108: def _RunCommand(self,
command):
On 2013/09/04 22:16:29, robertshield wrote:
> please add a brief method comment that mentions that the command is run from
the
> current file's dir

Done.

[grt (UTC plus 2), 2013-09-04 23:15:17]

lgtm as-is.

alternatively, is there an advantage to having the commands be separate
executable run in their own python interpreter rather than functions run within
the main test harness? this would avoid the cwd problem, as well as potentially
reduce overhead.

[gab, 2013-09-05 00:10:23]

On 2013/09/04 23:15:17, grt wrote:
> lgtm as-is.
> 
> alternatively, is there an advantage to having the commands be separate
> executable run in their own python interpreter rather than functions run
within
> the main test harness? this would avoid the cwd problem, as well as
potentially
> reduce overhead.

Yes there is, this executes whatever the command is; sometimes that's an exe;
this code doesn't need to know.

[Mathieu, 2013-09-05 00:22:26]

lgtm

[sukolsak, 2013-09-05 00:38:21]

On 2013/09/04 23:15:17, grt wrote:
> lgtm as-is.
> 
> alternatively, is there an advantage to having the commands be separate
> executable run in their own python interpreter rather than functions run
within
> the main test harness? this would avoid the cwd problem, as well as
potentially
> reduce overhead.

Thanks. One advantage that I can think of is that we don't need to distinguish
between internal commands and external commands and it also makes the config
file format simpler.

[commit-bot: I haz the power, 2013-09-05 00:41:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sukolsak@chromium.org/23557009/10001

[commit-bot: I haz the power, 2013-09-05 01:52:56]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-09-05 03:42:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sukolsak@chromium.org/23557009/10001

[commit-bot: I haz the power, 2013-09-05 04:11:09]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-09-05 04:18:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sukolsak@chromium.org/23557009/10001

[commit-bot: I haz the power, 2013-09-05 04:47:14]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-09-05 05:06:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sukolsak@chromium.org/23557009/10001

[commit-bot: I haz the power, 2013-09-05 05:32:14]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-09-05 06:17:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sukolsak@chromium.org/23557009/10001

[commit-bot: I haz the power, 2013-09-05 06:43:31]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-09-05 06:45:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sukolsak@chromium.org/23557009/10001

[commit-bot: I haz the power, 2013-09-05 07:14:08]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-09-05 07:32:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sukolsak@chromium.org/23557009/10001

[commit-bot: I haz the power, 2013-09-05 07:34:20]

Change committed as 221361