Save password bubble pops up automatically

chrome/browser/ui/views/location_bar/location_bar_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 365 matching lines @@
   static int GetBuiltInHorizontalPaddingForChildViews();
 
   // Returns the thickness of any visible left and right edge, in pixels.
   int GetHorizontalEdgeThickness() const;
 
   // The same, but for the top and bottom edges.
   int vertical_edge_thickness() const {
     return is_popup_mode_ ? kPopupEdgeThickness : kNormalEdgeThickness;
   }
 
   // Update the visibility state of the Content Blocked icons to reflect what is

[Peter Kasting, 2013/09/05 06:55:19]

Nit: Update -> Updates

[npentrel, 2013/09/05 08:28:09]

Done.

   // actually blocked on the current page.

[Peter Kasting, 2013/09/05 06:55:19]

Nit: Add to end:

Calling this function should always eventually be followed by calling Layout()
and then UpdateContentSettingViewsPostLayout(), to ensure the icons can
completely update their state.

[npentrel, 2013/09/05 08:28:09]

Done.

-  void RefreshContentSettingViews();
+  void UpdateContentSettingViewsPreLayout();
+
+  // Updates after the correct screen coordinates have been set for icons.

[Peter Kasting, 2013/09/05 06:55:19]

Nit: How about:

Allows content setting icons to perform any updating which can't complete until
after the icons have been correctly laid out.  This should be called after
UpdateContentSettingViewsPreLayout() and a subsequent Layout().

[npentrel, 2013/09/05 08:28:09]

Done.

+  void UpdateContentSettingViewsPostLayout();
 
   // Delete all page action views that we have created.
   void DeletePageActionViews();
 
   // Update the views for the Page Actions, to reflect state changes for
   // PageActions.
   void RefreshPageActionViews();
 
   // Returns the number of scripts currently running on the page.
   size_t ScriptBubbleScriptsRunning();
@@ skipping 132 matching lines @@
   // in the right location.
   int animation_offset_;
 
   // Used to register for notifications received by NotificationObserver.
   content::NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(LocationBarView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_