Save password bubble pops up automatically

chrome/browser/ui/views/location_bar/location_bar_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
 
 #include <algorithm>
 #include <map>
 
 #include "base/command_line.h"
@@ skipping 368 matching lines @@
   AddChildView(star_view_);
 
   registrar_.Add(this,
                  chrome::NOTIFICATION_EXTENSION_LOCATION_BAR_UPDATED,
                  content::Source<Profile>(profile_));
 
   // Initialize the location entry. We do this to avoid a black flash which is
   // visible when the location entry has just been initialized.
   Update(NULL);
 
   OnChanged();

[Peter Kasting, 2013/09/04 20:59:11]

This call can be nuked since it happens at the end of Update().

[npentrel, 2013/09/04 21:50:18]

I don't think I understand what you mean. 

[Peter Kasting, 2013/09/04 21:52:01]

Update(NULL);  // This calls OnChanged() directly before returning.
OnChanged();  // This isn't necessary, Update(NULL) just called it.  Remove.

[npentrel, 2013/09/04 22:19:55]

Done.

 }
 
 bool LocationBarView::IsInitialized() const {
   return location_entry_view_ != NULL;
 }
 
 SkColor LocationBarView::GetColor(ToolbarModel::SecurityLevel security_level,
                                   ColorKind kind) const {
   const ui::NativeTheme* native_theme = GetNativeTheme();
   switch (kind) {
@@ skipping 116 matching lines @@
                                          star_enabled);
   if (star_view_)
     star_view_->SetVisible(star_enabled);
 
   if (contents)
     location_entry_->OnTabChanged(contents);
   else
     location_entry_->Update();
 
   OnChanged();
+  UpdatePostLayout();
 }
 
 void LocationBarView::UpdateContentSettingsIcons() {
   RefreshContentSettingViews();
 
   Layout();
+  UpdatePostLayout();
   SchedulePaint();
 }
 
 void LocationBarView::UpdatePageActions() {
   size_t count_before = page_action_views_.size();
   RefreshPageActionViews();
   RefreshScriptBubble();
   if (page_action_views_.size() != count_before) {
     content::NotificationService::current()->Notify(
         chrome::NOTIFICATION_EXTENSION_PAGE_ACTION_COUNT_CHANGED,
@@ skipping 585 matching lines @@
   return (ui::GetDisplayLayout() == ui::LAYOUT_TOUCH) ?
       GetItemPadding() / 2 : 0;
 }
 
 int LocationBarView::GetHorizontalEdgeThickness() const {
   // In maximized popup mode, there isn't any edge.
   return (is_popup_mode_ && browser_ && browser_->window() &&
       browser_->window()->IsMaximized()) ? 0 : vertical_edge_thickness();
 }
 
 void LocationBarView::RefreshContentSettingViews() {

[Peter Kasting, 2013/09/04 20:59:11]

Nit: Why don't e name these functions UpdateContentSettingViewsPreLayout() and
UpdateContentSettingViewsPostLayout().

[npentrel, 2013/09/04 21:50:18]

Done.

   for (ContentSettingViews::const_iterator i(content_setting_views_.begin());
        i != content_setting_views_.end(); ++i) {
-    (*i)->Update(GetToolbarModel()->input_in_progress() ?
+    (*i)->UpdatePreLayout(GetToolbarModel()->input_in_progress() ?
         NULL : GetWebContents());
   }
 }
+
+void LocationBarView::UpdatePostLayout() {
+  for (ContentSettingViews::const_iterator i(content_setting_views_.begin());
+       i != content_setting_views_.end(); ++i) {
+    (*i)->UpdatePostLayout(GetToolbarModel()->input_in_progress() ?
+        NULL : GetWebContents());
+  }
+}
 
 void LocationBarView::DeletePageActionViews() {
   for (PageActionViews::const_iterator i(page_action_views_.begin());
        i != page_action_views_.end(); ++i)
     RemoveChildView(*i);
   STLDeleteElements(&page_action_views_);
 }
 
 void LocationBarView::RefreshPageActionViews() {
   if (is_popup_mode_)
@@ skipping 399 matching lines @@
 int LocationBarView::GetInternalHeight(bool use_preferred_size) {
   int total_height =
       use_preferred_size ? GetPreferredSize().height() : height();
   return std::max(total_height - (vertical_edge_thickness() * 2), 0);
 }
 
 bool LocationBarView::HasValidSuggestText() const {
   return suggested_text_view_->visible() &&
       !suggested_text_view_->size().IsEmpty();
 }