Save password bubble pops up automatically

chrome/browser/ui/content_settings/content_setting_image_model.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/content_settings/content_setting_image_model.h"
 
 #include "chrome/browser/content_settings/host_content_settings_map.h"
 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
 #include "chrome/browser/prerender/prerender_manager.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 46 matching lines @@
   ContentSettingMIDISysExImageModel();
 
   virtual void UpdateFromWebContents(WebContents* web_contents) OVERRIDE;
 };
 
 class ContentSettingSavePasswordImageModel : public ContentSettingImageModel {
  public:
   ContentSettingSavePasswordImageModel();
 
   virtual void UpdateFromWebContents(WebContents* web_contents) OVERRIDE;
+  virtual bool ShouldShowBubbleOnBlockage();

[Peter Kasting, 2013/09/04 20:59:11]

OVERRIDE

[npentrel, 2013/09/04 21:50:18]

Done.

 };
 
 namespace {
 
 struct ContentSettingsTypeIdEntry {
   ContentSettingsType type;
   int id;
 };
 
 int GetIdForContentType(const ContentSettingsTypeIdEntry* entries,
@@ skipping 149 matching lines @@
       set_icon(IDR_SAVE_PASSWORD);
       set_visible(true);
       break;
     case TabSpecificContentSettings::NO_PASSWORD_TO_BE_SAVED:
       set_icon(IDR_SAVE_PASSWORD);
       set_visible(false);
       break;
   }
 }
 
+bool ContentSettingSavePasswordImageModel::ShouldShowBubbleOnBlockage() {
+  return true;
+}
+
 ContentSettingMediaImageModel::ContentSettingMediaImageModel(
     ContentSettingsType type)
     : ContentSettingImageModel(type) {
 }
 
 void ContentSettingMediaImageModel::UpdateFromWebContents(
     WebContents* web_contents) {
   set_visible(false);
 
   // As long as a single icon is used to display the status of the camera and
@@ skipping 124 matching lines @@
 }
 
 ContentSettingImageModel::ContentSettingImageModel(
     ContentSettingsType content_settings_type)
     : content_settings_type_(content_settings_type),
       is_visible_(false),
       icon_(0),
       explanatory_string_id_(0) {
 }
 
+bool ContentSettingImageModel::ShouldShowBubbleOnBlockage() {
+  return false;
+}
+
 // static
 ContentSettingImageModel*
     ContentSettingImageModel::CreateContentSettingImageModel(
     ContentSettingsType content_settings_type) {
   switch (content_settings_type) {
     case CONTENT_SETTINGS_TYPE_GEOLOCATION:
       return new ContentSettingGeolocationImageModel();
     case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
       return new ContentSettingNotificationsImageModel();
     case CONTENT_SETTINGS_TYPE_PROTOCOL_HANDLERS:
       return new ContentSettingRPHImageModel();
     case CONTENT_SETTINGS_TYPE_MEDIASTREAM:
     case CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC:
     case CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA:
       return new ContentSettingMediaImageModel(content_settings_type);
     case CONTENT_SETTINGS_TYPE_MIDI_SYSEX:
       return new ContentSettingMIDISysExImageModel();
     case CONTENT_SETTINGS_TYPE_SAVE_PASSWORD:
       return new ContentSettingSavePasswordImageModel();
     default:
       return new ContentSettingBlockedImageModel(content_settings_type);
   }
 }