Save password bubble pops up automatically

chrome/browser/ui/views/location_bar/content_setting_image_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_CONTENT_SETTING_IMAGE_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_CONTENT_SETTING_IMAGE_VIEW_H_
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/common/content_settings_types.h"
 #include "ui/base/animation/animation_delegate.h"
@@ skipping 23 matching lines @@
                                 public views::WidgetObserver {
  public:
   ContentSettingImageView(ContentSettingsType content_type,
                           LocationBarView* parent,
                           const gfx::Font& font,
                           int font_y_offset,
                           SkColor text_color,
                           SkColor parent_background_color);
   virtual ~ContentSettingImageView();
 
+  // Updates the decoration from the shown WebContents after layouting has
+  // happened. This is necessary to get the right coordinates for the shown
+  // icons.

[Peter Kasting, 2013/09/03 23:50:43]

This comment seems like it's on the wrong function.

Nit: You might also want something slightly more generic here, and then a more
specific comment in the implementation.  Something like "Perform any updates
which depend on the image having already been laid out by the owning
LocationBarView."

[npentrel, 2013/09/04 09:55:36]

Done.

+  void UpdatePreLayout(content::WebContents* web_contents);
+
   // Update the decoration from the shown WebContents.
-  void Update(content::WebContents* web_contents);
+  void UpdatePostLayout(content::WebContents* web_contents);
 
  private:
   // Number of milliseconds spent animating open; also the time spent animating
   // closed.
   static const int kOpenTimeMS;
 
   // The total animation time, including open and close as well as an
   // intervening "stay open" period.
   static const int kAnimationDurationMS;
 
@@ skipping 34 matching lines @@
   views::Label* text_label_;
   ui::SlideAnimation slide_animator_;
   bool pause_animation_;
   double pause_animation_state_;
   views::Widget* bubble_widget_;
 
   DISALLOW_COPY_AND_ASSIGN(ContentSettingImageView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_CONTENT_SETTING_IMAGE_VIEW_H_