Issue 23557002: Fix definition of V8_*_C() macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23557002: Fix definition of V8_*_C() macros. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer

Modified:
7 years, 3 months ago

Reviewers:
Sven Panne, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix definition of V8_*_C() macros. Make V8_INT64_C() and V8_UINT64_C() available in 32-bit mode as well, so we can write readable constants (base 10) instead of having to obfuscate them using V8_2PART_UINT64_C(). R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16366

Patch Set 1 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -20 lines)			Patch
	M	include/v8config.h	View		2 chunks	+5 lines, -1 line	0 comments	Download
	M	src/globals.h	View		1 chunk	+24 lines, -19 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

7 years, 3 months ago (2013-08-27 14:16:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r16366 (presubmit successful).

Expand Messages | Collapse Messages