Issue 2355683002: Revert "Make CPDF_IndirectObjectHolder use unique_ptr to objects"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2355683002: Revert "Make CPDF_IndirectObjectHolder use unique_ptr to objects" (Closed)

Created:
4 years, 3 months ago by Tom Sepez

Modified:
4 years, 3 months ago

Reviewers:
dsinclair

CC:
pdfium-reviews_googlegroups.com

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Revert "Make CPDF_IndirectObjectHolder use unique_ptr to objects" This reverts commit c8544d634a1993e2592e41458be215fcd0956031. TBR=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/81e1e3fd2d33478733e47bd007b76fac1a663e74

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -17 lines)			Patch
M	core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/fpdfapi/fpdf_parser/cfdf_document.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp	View	5 chunks	+18 lines, -8 lines	0 comments	Download
M	core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h	View	4 chunks	+5 lines, -4 lines	0 comments	Download
M	core/fpdfapi/fpdf_parser/include/cpdf_object.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

Tom Sepez

4 years, 3 months ago (2016-09-19 21:17:11 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
81e1e3fd2d33478733e47bd007b76fac1a663e74 (tree was closed).