Selection-autoscroll should be triggered when the pointer is in the border belt.

Selection-autoscroll should be triggered when the pointer is in the border belt.

Previously, selection-autoscroll can only be triggered when the pointer is
outside the border. This generally works fine. However, when the browser is
maximized and there is no panel or dock at the bottom of user's desktop, the
pointer can't move out the border as it can't move out the screen, so
selection-autoscroll can't be triggered.

This patch implements the selection-autoscroll according to drag-and-drop
autoscroll, so that the autoscroll will be triggered when the pointer is in
the border belt area (within a certain distance to the border and inside).

BUG=645108
Committed: https://crrev.com/b7026e2d381d6f3f8d46394bf173b92c2826a5d5
Cr-Commit-Position: refs/heads/master@{#419654}

[sunyunjia, 2016-09-19 20:00:06]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 20:01:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunyunjia, 2016-09-19 20:06:56]

Description was changed from

==========
Selection-autoscroll should be triggered when the pointer is in the border belt.

BUG=645108
==========

to

==========
Selection-autoscroll should be triggered when the pointer is in the border belt.

Previously, selection-autoscroll can only be triggered when the pointer is
outside the border. This generally works fine. However, when the browser is
maximized and there is no panel or dock at the bottom of user's desktop, the
pointer can't move out the border as it can't move out the screen, so
selection-autoscroll can't be triggered.

This patch implements the selection-autoscroll according to drag-and-drop
autoscroll, so that the autoscroll will be triggered when the pointer is in the
border belt area.

BUG=645108
==========

[sunyunjia, 2016-09-19 20:06:56]

sunyunjia@chromium.org changed reviewers:
+ bokan@chromium.org

[sunyunjia, 2016-09-19 20:11:32]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 20:11:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunyunjia, 2016-09-19 20:25:00]

Description was changed from

==========
Selection-autoscroll should be triggered when the pointer is in the border belt.

Previously, selection-autoscroll can only be triggered when the pointer is
outside the border. This generally works fine. However, when the browser is
maximized and there is no panel or dock at the bottom of user's desktop, the
pointer can't move out the border as it can't move out the screen, so
selection-autoscroll can't be triggered.

This patch implements the selection-autoscroll according to drag-and-drop
autoscroll, so that the autoscroll will be triggered when the pointer is in the
border belt area.

BUG=645108
==========

to

==========
Selection-autoscroll should be triggered when the pointer is in the border belt.

Previously, selection-autoscroll can only be triggered when the pointer is
outside the border. This generally works fine. However, when the browser is
maximized and there is no panel or dock at the bottom of user's desktop, the
pointer can't move out the border as it can't move out the screen, so
selection-autoscroll can't be triggered.

This patch implements the selection-autoscroll according to drag-and-drop
autoscroll, so that the autoscroll will be triggered when the pointer is in
the
border belt area.

BUG=645108
==========

[sunyunjia, 2016-09-19 20:25:16]

Description was changed from

==========
Selection-autoscroll should be triggered when the pointer is in the border belt.

Previously, selection-autoscroll can only be triggered when the pointer is
outside the border. This generally works fine. However, when the browser is
maximized and there is no panel or dock at the bottom of user's desktop, the
pointer can't move out the border as it can't move out the screen, so
selection-autoscroll can't be triggered.

This patch implements the selection-autoscroll according to drag-and-drop
autoscroll, so that the autoscroll will be triggered when the pointer is in
the
border belt area.

BUG=645108
==========

to

==========
Selection-autoscroll should be triggered when the pointer is in the border belt.

Previously, selection-autoscroll can only be triggered when the pointer is
outside the border. This generally works fine. However, when the browser is
maximized and there is no panel or dock at the bottom of user's desktop, the
pointer can't move out the border as it can't move out the screen, so
selection-autoscroll can't be triggered.

This patch implements the selection-autoscroll according to drag-and-drop
autoscroll, so that the autoscroll will be triggered when the pointer is in
the border belt area.

BUG=645108
==========

[sunyunjia, 2016-09-19 20:25:47]

PTAL, thanks!

[bokan, 2016-09-19 21:13:18]

https://codereview.chromium.org/2355643002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/events/selection-autoscroll-borderbelt.html
(right):

https://codereview.chromium.org/2355643002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/events/selection-autoscroll-borderbelt.html:4:
<body>
Nit: no <body> tag

https://codereview.chromium.org/2355643002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/events/selection-autoscroll-borderbelt.html:26:
console.log(scrollable.scrollTop);
Please remove the logging output.

https://codereview.chromium.org/2355643002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/events/selection-autoscroll-borderbelt.html:37:
// Autoscroll is occurred evey 0.05 sec.
Where does this constant come from? I see AutoscrollController.cpp has static
double autoscrollDelay but that's 0.2 sec and is only used in the drag and drop
case.

https://codereview.chromium.org/2355643002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/events/selection-autoscroll-borderbelt.html:38:
window.setTimeout(checkScrolled, 50);
We generally avoid using window.setTimeout in tests since it commonly leads to
flaky tests. Instead, we prefer to use requestAnimationFrame since that'll
execute on the next frame regardless of when that is. That requires though that
the autoscroll starts immediately (if there is indeed a constant delay, as asked
above, then rAF might not work).

Also, please remove the retry machinery.

[commit-bot: I haz the power, 2016-09-19 21:31:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 21:31:04]

Dry run: This issue passed the CQ dry run.

[sunyunjia, 2016-09-19 21:34:28]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[sunyunjia, 2016-09-19 21:35:10]

Thanks for "requestAnimationFrame"! PTAL.

[commit-bot: I haz the power, 2016-09-19 21:35:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bokan, 2016-09-19 21:41:26]

Thanks. Quick question: what is the definition of the border belt? It's not the
border because your test's drag ends before the border and the manual
instructions imply as much. Please define it in the description.

[sunyunjia, 2016-09-19 21:50:02]

Description was changed from

==========
Selection-autoscroll should be triggered when the pointer is in the border belt.

Previously, selection-autoscroll can only be triggered when the pointer is
outside the border. This generally works fine. However, when the browser is
maximized and there is no panel or dock at the bottom of user's desktop, the
pointer can't move out the border as it can't move out the screen, so
selection-autoscroll can't be triggered.

This patch implements the selection-autoscroll according to drag-and-drop
autoscroll, so that the autoscroll will be triggered when the pointer is in
the border belt area.

BUG=645108
==========

to

==========
Selection-autoscroll should be triggered when the pointer is in the border belt.

Previously, selection-autoscroll can only be triggered when the pointer is
outside the border. This generally works fine. However, when the browser is
maximized and there is no panel or dock at the bottom of user's desktop, the
pointer can't move out the border as it can't move out the screen, so
selection-autoscroll can't be triggered.

This patch implements the selection-autoscroll according to drag-and-drop
autoscroll, so that the autoscroll will be triggered when the pointer is in
the border belt area (within a certain distance to the border and inside).

BUG=645108
==========

[sunyunjia, 2016-09-19 21:53:20]

Done edited the description. Here is the pointer to border belt:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/La...

[sunyunjia, 2016-09-19 21:53:21]

Done edited the description. Here is the pointer to border belt:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/La...

[bokan, 2016-09-19 21:55:56]

Got it. Thanks! lgtm

[commit-bot: I haz the power, 2016-09-20 00:44:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 00:44:12]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sunyunjia, 2016-09-20 01:31:42]

The CQ bit was checked by sunyunjia@chromium.org

[commit-bot: I haz the power, 2016-09-20 01:33:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 02:30:04]

Description was changed from

==========
Selection-autoscroll should be triggered when the pointer is in the border belt.

Previously, selection-autoscroll can only be triggered when the pointer is
outside the border. This generally works fine. However, when the browser is
maximized and there is no panel or dock at the bottom of user's desktop, the
pointer can't move out the border as it can't move out the screen, so
selection-autoscroll can't be triggered.

This patch implements the selection-autoscroll according to drag-and-drop
autoscroll, so that the autoscroll will be triggered when the pointer is in
the border belt area (within a certain distance to the border and inside).

BUG=645108
==========

to

==========
Selection-autoscroll should be triggered when the pointer is in the border belt.

Previously, selection-autoscroll can only be triggered when the pointer is
outside the border. This generally works fine. However, when the browser is
maximized and there is no panel or dock at the bottom of user's desktop, the
pointer can't move out the border as it can't move out the screen, so
selection-autoscroll can't be triggered.

This patch implements the selection-autoscroll according to drag-and-drop
autoscroll, so that the autoscroll will be triggered when the pointer is in
the border belt area (within a certain distance to the border and inside).

BUG=645108
==========

[commit-bot: I haz the power, 2016-09-20 02:30:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-20 02:31:37]

Description was changed from

==========
Selection-autoscroll should be triggered when the pointer is in the border belt.

Previously, selection-autoscroll can only be triggered when the pointer is
outside the border. This generally works fine. However, when the browser is
maximized and there is no panel or dock at the bottom of user's desktop, the
pointer can't move out the border as it can't move out the screen, so
selection-autoscroll can't be triggered.

This patch implements the selection-autoscroll according to drag-and-drop
autoscroll, so that the autoscroll will be triggered when the pointer is in
the border belt area (within a certain distance to the border and inside).

BUG=645108
==========

to

==========
Selection-autoscroll should be triggered when the pointer is in the border belt.

Previously, selection-autoscroll can only be triggered when the pointer is
outside the border. This generally works fine. However, when the browser is
maximized and there is no panel or dock at the bottom of user's desktop, the
pointer can't move out the border as it can't move out the screen, so
selection-autoscroll can't be triggered.

This patch implements the selection-autoscroll according to drag-and-drop
autoscroll, so that the autoscroll will be triggered when the pointer is in
the border belt area (within a certain distance to the border and inside).

BUG=645108

Committed: https://crrev.com/b7026e2d381d6f3f8d46394bf173b92c2826a5d5
Cr-Commit-Position: refs/heads/master@{#419654}
==========

[commit-bot: I haz the power, 2016-09-20 02:31:37]

Patchset 3 (id:??) landed as
https://crrev.com/b7026e2d381d6f3f8d46394bf173b92c2826a5d5
Cr-Commit-Position: refs/heads/master@{#419654}