Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2223)

Unified Diff: android_webview/java/src/org/chromium/android_webview/ClientCertLookupTable.java

Issue 235563005: Add client cert support to android_webview (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: code review phase 1 Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/ClientCertLookupTable.java
diff --git a/android_webview/java/src/org/chromium/android_webview/ClientCertLookupTable.java b/android_webview/java/src/org/chromium/android_webview/ClientCertLookupTable.java
new file mode 100644
index 0000000000000000000000000000000000000000..65ef44aced532b94817952e80b88d17efce5de61
--- /dev/null
+++ b/android_webview/java/src/org/chromium/android_webview/ClientCertLookupTable.java
@@ -0,0 +1,76 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.android_webview;
+
+import org.chromium.net.AndroidPrivateKey;
+
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Map;
+import java.util.Set;
+
+/**
+ * Store user's client certificate decision for a host and port pair. Not
+ * thread-safe. All accesses are done on UI thread.
+ */
+public class ClientCertLookupTable {
+
+ /**
+ * A container for the certificate data.
+ */
+ public static class Cert {
+ AndroidPrivateKey privateKey;
+ byte[][] certChain;
+ public Cert(AndroidPrivateKey privateKey, byte[][] certChain) {
+ this.privateKey = privateKey;
+ byte[][] newChain = new byte[certChain.length][];
+ for (int i = 0; i < certChain.length; i++) {
+ newChain[i] = Arrays.copyOf(certChain[i], certChain[i].length);
+ }
+ this.certChain = newChain;
+ }
+ };
+
+ private final Map<String, Cert> mCerts;
+ private final Set<String> mDenieds;
+
+ // Clear client certificate preferences
+ public void clear() {
+ mCerts.clear();
+ mDenieds.clear();
+ }
+
+ public ClientCertLookupTable() {
+ mCerts = new HashMap<String, Cert>();
+ mDenieds = new HashSet<String>();
+ }
+
+ public void allow(String host, int port, AndroidPrivateKey privateKey, byte[][] chain) {
+ String host_and_port = hostAndPort(host, port);
+ mCerts.put(host_and_port, new Cert(privateKey, chain));
+ mDenieds.remove(host_and_port);
+ }
+
+ public void deny(String host, int port) {
+ String host_and_port = hostAndPort(host, port);
+ mCerts.remove(host_and_port);
+ mDenieds.add(host_and_port);
+ }
+
+ public Cert getCertData(String host, int port) {
+ return mCerts.get(hostAndPort(host, port));
+ }
+
+ public boolean isDenied(String host, int port) {
+ return mDenieds.contains(hostAndPort(host, port));
+ }
+
+ // TODO(sgurun) add a test for this. Not separating host and pair properly will be
+ // a security issue.
+ private static String hostAndPort(String host, int port) {
+ return host + ":" + port;
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698