Add client cert support to android_webview

android_webview/unittestjava/src/org/chromium/android_webview/unittest/MockAwContentsClientBridge.java

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.android_webview.unittest;
+
+import org.chromium.android_webview.AwContentsClientBridge;
+import org.chromium.android_webview.ClientCertLookupTable;
+import org.chromium.base.CalledByNative;
+import org.chromium.net.AndroidKeyStore;
+import org.chromium.net.AndroidPrivateKey;
+import org.chromium.net.DefaultAndroidKeyStore;
+
+class MockAwContentsClientBridge extends AwContentsClientBridge {

[boliu, 2014/04/16 02:57:46]

Does this compile? Doesn't the class need to be public? Maybe I don't know java
well enough...

[sgurun-gerrit only, 2014/04/17 15:10:51]

Of course it does. A class not declared public can be accessed from the package
(has package access).

On 2014/04/16 02:57:46, boliu wrote:

+
+    private String[] mKeyTypes;
+    private boolean mEarlyOutSelectClientCertificate = false;
+
+    public MockAwContentsClientBridge() {
+        super(new DefaultAndroidKeyStore(), new ClientCertLookupTable());
+    }
+
+    @Override
+    protected boolean selectClientCertificate(final long nativePtr, final String[] keyTypes,

[boliu, 2014/04/16 02:57:46]

Hmm, interesting question, can you override a private method that's not marked
final?

[sgurun-gerrit only, 2014/04/17 15:10:51]

1. you cannot override a private method since its accessor is private. (of
course you can have a method of same name in your class subtyping it, but this
is not overriding).
2. making a private method final has no effect. 

On 2014/04/16 02:57:46, boliu wrote:

+            byte[][] encodedPrincipals, final String host, final int port) {
+        if (mEarlyOutSelectClientCertificate) return false;
+        mKeyTypes = keyTypes;
+        return true;
+    }
+
+    @CalledByNative
+    private static MockAwContentsClientBridge getAwContentsClientBridge() {

[boliu, 2014/04/16 02:57:46]

s/get/create/

[sgurun-gerrit only, 2014/04/18 01:44:55]

Done.

[boliu, 2014/04/18 17:10:12]

Not done?

[sgurun-gerrit only, 2014/04/19 01:28:49]

forgot uploading the patch that has it.
On 2014/04/18 17:10:12, boliu wrote:

+        return new MockAwContentsClientBridge();
+    }
+
+    @CalledByNative
+    private AndroidPrivateKey getTestPrivateKey() {
+        return new AndroidPrivateKey() {
+            @Override
+            public AndroidKeyStore getKeyStore() {
+                return null;
+            }
+        };
+    }
+
+    @CalledByNative
+    private void setEarlyOutSelectClientCertificate(boolean earlyOut) {
+      mEarlyOutSelectClientCertificate = earlyOut;
+    }
+
+    @CalledByNative
+    private String[] getKeyTypes() {
+      return mKeyTypes;
+    }
+}