Issue 2355613003: Generate only AST based summaries in build mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2355613003: Generate only AST based summaries in build mode. (Closed)

Created:
4 years, 3 months ago by scheglov

Modified:
4 years, 3 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Generate only AST based summaries in build mode. Should we also remove fallback mode? R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1b10de1a86a7869e2177c3e98b5e061d7913b181

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -39 lines)			Patch
	M	pkg/analyzer_cli/lib/src/build_mode.dart	View		6 chunks	+6 lines, -33 lines	0 comments	Download
	M	pkg/analyzer_cli/lib/src/options.dart	View		3 chunks	+1 line, -6 lines	0 comments	Download

Total messages: 4 (1 generated)

Paul Berry

LGTM, thanks. Regarding fallback mode, yes, we should remove it too (it was a case ...

4 years, 3 months ago (2016-09-19 20:41:47 UTC) #2

scheglov

4 years, 3 months ago (2016-09-19 20:47:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1b10de1a86a7869e2177c3e98b5e061d7913b181 (presubmit successful).