Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: tools/test.dart

Issue 23556008: Revert revision 27014 "Remove restriction on the number of IE processes running simultainiously" (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/test.dart
===================================================================
--- tools/test.dart (revision 27017)
+++ tools/test.dart (working copy)
@@ -154,9 +154,13 @@
}
}
- // If people use selenium they will have issues if we use more than one
- // ie browser at a time.
- if (conf['runtime'].startsWith('ie') && !conf['use_browser_controller']) {
+ if (conf['runtime'].startsWith('ie')) {
+ // NOTE: We've experienced random timeouts of tests on ie9/ie10. The
+ // underlying issue has not been determined yet. Our current hypothesis
+ // is that windows does not handle the IE processes independently.
+ // If we have more than one browser and kill a browser we are seeing
+ // issues with starting up a new browser just after killing the hanging
+ // browser.
maxBrowserProcesses = 1;
} else if (conf['runtime'].startsWith('safari') &&
conf['use_browser_controller']) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698