Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2355593002: Remove CPDF_Object::Destroy { delete this; } (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove CPDF_Object::Destroy { delete this; } We can delete this just fine on our own. Committed: https://pdfium.googlesource.com/pdfium/+/c6c2e36f59f54b17d9e2c54a2003166e79ccb5e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_object.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_object.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Tom Sepez
Dan, for review. First step in making object lifetimes saner so we can reason about ...
4 years, 3 months ago (2016-09-19 18:47:04 UTC) #5
dsinclair
lgtm
4 years, 3 months ago (2016-09-19 18:50:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355593002/1
4 years, 3 months ago (2016-09-19 19:03:05 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 19:08:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/c6c2e36f59f54b17d9e2c54a2003166e79cc...

Powered by Google App Engine
This is Rietveld 408576698