Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2355583002: stop using (deprecated) setClipRegion, add flag for new clipop type (Closed)

Created:
4 years, 3 months ago by reed1
Modified:
4 years, 3 months ago
Reviewers:
danakj, f(malita), boliu
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

stop using (deprecated) setClipRegion, add flag for new clipop type future skia CL that will migrate to specialized type for clipops : https://codereview.chromium.org/2355483002 BUG=skia:3191, skia:5773 Committed: https://crrev.com/688c0c0cae1cbcfbaa678d781bec0687d89d3eba Cr-Commit-Position: refs/heads/master@{#419574}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 4

Patch Set 3 : fix ) typo on android #

Patch Set 4 : rename to DrawRectWithColor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -16 lines) Patch
M content/renderer/android/synchronous_compositor_proxy.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M skia/config/SkUserConfig.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/skbitmap_operations_unittest.cc View 1 2 3 2 chunks +20 lines, -14 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
reed1
ptal
4 years, 3 months ago (2016-09-19 19:29:24 UTC) #10
danakj
LGTM w/ comments https://codereview.chromium.org/2355583002/diff/20001/ui/gfx/skbitmap_operations_unittest.cc File ui/gfx/skbitmap_operations_unittest.cc (right): https://codereview.chromium.org/2355583002/diff/20001/ui/gfx/skbitmap_operations_unittest.cc#newcode509 ui/gfx/skbitmap_operations_unittest.cc:509: void SetRectColor(SkCanvas* canvas, Can you name ...
4 years, 3 months ago (2016-09-19 19:35:52 UTC) #13
reed1
https://codereview.chromium.org/2355583002/diff/20001/ui/gfx/skbitmap_operations_unittest.cc File ui/gfx/skbitmap_operations_unittest.cc (right): https://codereview.chromium.org/2355583002/diff/20001/ui/gfx/skbitmap_operations_unittest.cc#newcode509 ui/gfx/skbitmap_operations_unittest.cc:509: void SetRectColor(SkCanvas* canvas, On 2016/09/19 19:35:51, danakj wrote: > ...
4 years, 3 months ago (2016-09-19 19:42:38 UTC) #14
boliu
lgtm
4 years, 3 months ago (2016-09-19 19:43:08 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355583002/60001
4 years, 3 months ago (2016-09-19 19:43:54 UTC) #18
f(malita)
lgtm
4 years, 3 months ago (2016-09-19 19:45:26 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-19 21:48:00 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:50:25 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/688c0c0cae1cbcfbaa678d781bec0687d89d3eba
Cr-Commit-Position: refs/heads/master@{#419574}

Powered by Google App Engine
This is Rietveld 408576698