Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2355583002:
stop using (deprecated) setClipRegion, add flag for new clipop type (Closed)
Descriptionstop using (deprecated) setClipRegion, add flag for new clipop type
future skia CL that will migrate to specialized type for clipops : https://codereview.chromium.org/2355483002
BUG=skia:3191, skia:5773
Committed: https://crrev.com/688c0c0cae1cbcfbaa678d781bec0687d89d3eba
Cr-Commit-Position: refs/heads/master@{#419574}
Patch Set 1 #Patch Set 2 : rebase #
Total comments: 4
Patch Set 3 : fix ) typo on android #Patch Set 4 : rename to DrawRectWithColor #
Messages
Total messages: 23 (15 generated)
Description was changed from ========== stop using (deprecated) setClipRegion, add flag for new clipop type BUG= ========== to ========== stop using (deprecated) setClipRegion, add flag for new clipop type future skia CL that will migrate to specialized type for clipops : https://codereview.chromium.org/2355483002 BUG=skia:3191 ==========
reed@google.com changed reviewers: + boliu@chromium.org, danakj@chromium.org, fmalita@chromium.org
The CQ bit was checked by reed@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== stop using (deprecated) setClipRegion, add flag for new clipop type future skia CL that will migrate to specialized type for clipops : https://codereview.chromium.org/2355483002 BUG=skia:3191 ========== to ========== stop using (deprecated) setClipRegion, add flag for new clipop type future skia CL that will migrate to specialized type for clipops : https://codereview.chromium.org/2355483002 BUG=skia:3191, skia:5773 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by reed@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ptal
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
LGTM w/ comments https://codereview.chromium.org/2355583002/diff/20001/ui/gfx/skbitmap_operati... File ui/gfx/skbitmap_operations_unittest.cc (right): https://codereview.chromium.org/2355583002/diff/20001/ui/gfx/skbitmap_operati... ui/gfx/skbitmap_operations_unittest.cc:509: void SetRectColor(SkCanvas* canvas, Can you name this DrawRectWithColor? Set sounds like a setter on a class https://codereview.chromium.org/2355583002/diff/20001/ui/gfx/skbitmap_operati... ui/gfx/skbitmap_operations_unittest.cc:518: canvas->drawRect(SkRect::Make({left, top, right, bottom}), paint); Can you use SkIRect::MakeLTRB() so we can see the types involved? (I think that's what this is constructing?)
https://codereview.chromium.org/2355583002/diff/20001/ui/gfx/skbitmap_operati... File ui/gfx/skbitmap_operations_unittest.cc (right): https://codereview.chromium.org/2355583002/diff/20001/ui/gfx/skbitmap_operati... ui/gfx/skbitmap_operations_unittest.cc:509: void SetRectColor(SkCanvas* canvas, On 2016/09/19 19:35:51, danakj wrote: > Can you name this DrawRectWithColor? Set sounds like a setter on a class Done. https://codereview.chromium.org/2355583002/diff/20001/ui/gfx/skbitmap_operati... ui/gfx/skbitmap_operations_unittest.cc:518: canvas->drawRect(SkRect::Make({left, top, right, bottom}), paint); On 2016/09/19 19:35:52, danakj wrote: > Can you use SkIRect::MakeLTRB() so we can see the types involved? (I think > that's what this is constructing?) Done.
The CQ bit was checked by reed@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org Link to the patchset: https://codereview.chromium.org/2355583002/#ps60001 (title: "rename to DrawRectWithColor")
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Message was sent while issue was closed.
Description was changed from ========== stop using (deprecated) setClipRegion, add flag for new clipop type future skia CL that will migrate to specialized type for clipops : https://codereview.chromium.org/2355483002 BUG=skia:3191, skia:5773 ========== to ========== stop using (deprecated) setClipRegion, add flag for new clipop type future skia CL that will migrate to specialized type for clipops : https://codereview.chromium.org/2355483002 BUG=skia:3191, skia:5773 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== stop using (deprecated) setClipRegion, add flag for new clipop type future skia CL that will migrate to specialized type for clipops : https://codereview.chromium.org/2355483002 BUG=skia:3191, skia:5773 ========== to ========== stop using (deprecated) setClipRegion, add flag for new clipop type future skia CL that will migrate to specialized type for clipops : https://codereview.chromium.org/2355483002 BUG=skia:3191, skia:5773 Committed: https://crrev.com/688c0c0cae1cbcfbaa678d781bec0687d89d3eba Cr-Commit-Position: refs/heads/master@{#419574} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/688c0c0cae1cbcfbaa678d781bec0687d89d3eba Cr-Commit-Position: refs/heads/master@{#419574} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
