Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2355563002: Add SK_ADDING_src_ports_SkFontConfigInterface_cpp. (Closed)

Created:
4 years, 3 months ago by bungeman-chromium
Modified:
4 years, 3 months ago
Reviewers:
bungeman-skia
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SK_ADDING_src_ports_SkFontConfigInterface_cpp. A few method definitions in Skia need to be moved into a new cpp file, while this define is active the old code will continue to compile until the Chromium build of Skia can be updated. NOTRY=true Adds a define. Built locally, but analyze says "No compile necessary". Committed: https://crrev.com/1834f8bc4db436639d8f940f5973d7061172abd5 Cr-Commit-Position: refs/heads/master@{#419506}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M skia/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
bungeman-skia
lgtm
4 years, 3 months ago (2016-09-19 18:01:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355563002/1
4 years, 3 months ago (2016-09-19 18:11:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 18:16:34 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 18:18:32 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1834f8bc4db436639d8f940f5973d7061172abd5
Cr-Commit-Position: refs/heads/master@{#419506}

Powered by Google App Engine
This is Rietveld 408576698