Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5792)

Unified Diff: chrome/browser/ui/webui/md_history_ui.cc

Issue 2355543003: Invalidate the page state when restoring WebUIs (Closed)
Patch Set: add test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/md_history_ui.cc
diff --git a/chrome/browser/ui/webui/md_history_ui.cc b/chrome/browser/ui/webui/md_history_ui.cc
index 2b1d688ae963a987b5ce7a1c9f6cbf1026a14ae8..075d4e59b08cfc9753e3446fa4cd0053438e1cb4 100644
--- a/chrome/browser/ui/webui/md_history_ui.cc
+++ b/chrome/browser/ui/webui/md_history_ui.cc
@@ -32,7 +32,8 @@
namespace {
-content::WebUIDataSource* CreateMdHistoryUIHTMLSource(Profile* profile) {
+content::WebUIDataSource* CreateMdHistoryUIHTMLSource(Profile* profile,
+ bool use_test_title) {
PrefService* prefs = profile->GetPrefs();
content::WebUIDataSource* source =
@@ -96,7 +97,10 @@ content::WebUIDataSource* CreateMdHistoryUIHTMLSource(Profile* profile) {
source->AddLocalizedString("signInPromo", IDS_MD_HISTORY_SIGN_IN_PROMO);
source->AddLocalizedString("signInPromoDesc",
IDS_MD_HISTORY_SIGN_IN_PROMO_DESC);
- source->AddLocalizedString("title", IDS_HISTORY_TITLE);
+ if (use_test_title)
+ source->AddString("title", "MD History");
+ else
+ source->AddLocalizedString("title", IDS_HISTORY_TITLE);
source->AddString(
"sidebarFooter",
@@ -191,6 +195,8 @@ content::WebUIDataSource* CreateMdHistoryUIHTMLSource(Profile* profile) {
} // namespace
+bool MdHistoryUI::use_test_title = false;
Dan Beam 2016/09/21 06:19:17 should this technically be g_use_test_title_?
+
MdHistoryUI::MdHistoryUI(content::WebUI* web_ui) : WebUIController(web_ui) {
Profile* profile = Profile::FromWebUI(web_ui);
web_ui->AddMessageHandler(new BrowsingHistoryHandler());
@@ -201,7 +207,9 @@ MdHistoryUI::MdHistoryUI(content::WebUI* web_ui) : WebUIController(web_ui) {
web_ui->AddMessageHandler(new HistoryLoginHandler());
}
- content::WebUIDataSource::Add(profile, CreateMdHistoryUIHTMLSource(profile));
+ content::WebUIDataSource::Add(
+ profile,
+ CreateMdHistoryUIHTMLSource(profile, MdHistoryUI::use_test_title));
Dan Beam 2016/09/21 06:19:17 I don't technically think you need this MdHistoryU
}
MdHistoryUI::~MdHistoryUI() {}
« no previous file with comments | « chrome/browser/ui/webui/md_history_ui.h ('k') | components/sessions/content/content_serialized_navigation_driver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698