Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2355543002: Issue 27390. Visit 'ExecutableElement.typeParameters'. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 27390. Visit 'ExecutableElement.typeParameters'. Otherwise incremental updaters fail to update type parameters' offsets, which causes failures later in DeclarationResolver when apply elements to re-created AST. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/27390 Committed: https://github.com/dart-lang/sdk/commit/dd5a6c2265f87ceecda50a886664f111c93c7d05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 3 months ago (2016-09-19 17:27:49 UTC) #1
Brian Wilkerson
lgtm
4 years, 3 months ago (2016-09-19 18:21:16 UTC) #2
scheglov
4 years, 3 months ago (2016-09-19 19:17:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dd5a6c2265f87ceecda50a886664f111c93c7d05 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698