Support sideloaded fonts for DirectWrite

Support sideloaded fonts for DirectWrite

Chrome side is: https://codereview.chromium.org/231763003/

This isn't perfect (using the family name directly rather than
doing a name/style/etc. fallback based lookup), but it's simple
and works sufficiently for layout tests and local developer use
of custom fonts. If we want to in the future, the same interface
could be used in conjunction with some skia changes to support
custom font collections, which would get the full style matching
support.

TBR=dglazkov@chromium.org
R=eae@chromium.org
BUG=333029
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171400

[eae, 2014-04-12 10:51:33]

Nice! LGTM w/nits.

https://codereview.chromium.org/235553003/diff/10001/Source/platform/fonts/Fo...
File Source/platform/fonts/FontCache.h (right):

https://codereview.chromium.org/235553003/diff/10001/Source/platform/fonts/Fo...
Source/platform/fonts/FontCache.h:107: static void
addSideloadedFont(SkTypeface*);
How about addSideloadedFontForTesting to discourage further use and make it
clear that it is not intended for widespread use?

https://codereview.chromium.org/235553003/diff/10001/Source/platform/fonts/sk...
File Source/platform/fonts/skia/FontCacheSkia.cpp (right):

https://codereview.chromium.org/235553003/diff/10001/Source/platform/fonts/sk...
Source/platform/fonts/skia/FontCacheSkia.cpp:129: HashMap<String,
SkTypeface*>::iterator i = s_sideloadedFonts->find(name.data());
The blink convention is to only use the variable name i for indices. How about
"sideloadedFont" or "it" instead?

[scottmg, 2014-04-12 15:42:38]

https://codereview.chromium.org/235553003/diff/10001/Source/platform/fonts/Fo...
File Source/platform/fonts/FontCache.h (right):

https://codereview.chromium.org/235553003/diff/10001/Source/platform/fonts/Fo...
Source/platform/fonts/FontCache.h:107: static void
addSideloadedFont(SkTypeface*);
On 2014/04/12 10:51:33, eae wrote:
> How about addSideloadedFontForTesting to discourage further use and make it
> clear that it is not intended for widespread use?

SG, Done.

https://codereview.chromium.org/235553003/diff/10001/Source/platform/fonts/sk...
File Source/platform/fonts/skia/FontCacheSkia.cpp (right):

https://codereview.chromium.org/235553003/diff/10001/Source/platform/fonts/sk...
Source/platform/fonts/skia/FontCacheSkia.cpp:129: HashMap<String,
SkTypeface*>::iterator i = s_sideloadedFonts->find(name.data());
On 2014/04/12 10:51:33, eae wrote:
> The blink convention is to only use the variable name i for indices. How about
> "sideloadedFont" or "it" instead? 

Done.

[scottmg, 2014-04-12 15:45:07]

tbr dglazkov for plumbing in

Source/web/win/WebFontRendering.cpp
public/web/win/WebFontRendering.h

[scottmg, 2014-04-12 16:34:17]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-04-12 16:34:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/235553003/30001

[commit-bot: I haz the power, 2014-04-12 20:42:13]

Change committed as 171400