Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2355523002: Remove dead code in CCodec_IccModule (Closed)

Created:
4 years, 3 months ago by kcwu
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove dead code in CCodec_IccModule TEST=build pdfium and chromium BUG=pdfium:599 Committed: https://pdfium.googlesource.com/pdfium/+/a5b37f6b916f1a35d3fbb3f0b41e9e4b4d265370

Patch Set 1 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -376 lines) Patch
M core/fxcodec/codec/ccodec_iccmodule.h View 2 chunks +0 lines, -59 lines 0 comments Download
M core/fxcodec/codec/fx_codec_icc.cpp View 3 chunks +0 lines, -317 lines 1 comment Download

Messages

Total messages: 10 (5 generated)
kcwu
PTAL
4 years, 3 months ago (2016-09-19 16:33:56 UTC) #4
Tom Sepez
lgtm
4 years, 3 months ago (2016-09-19 16:38:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355523002/20001
4 years, 3 months ago (2016-09-19 16:39:19 UTC) #7
Tom Sepez
https://codereview.chromium.org/2355523002/diff/20001/core/fxcodec/codec/fx_codec_icc.cpp File core/fxcodec/codec/fx_codec_icc.cpp (right): https://codereview.chromium.org/2355523002/diff/20001/core/fxcodec/codec/fx_codec_icc.cpp#newcode17 core/fxcodec/codec/fx_codec_icc.cpp:17: struct CLcmsCmm { note: as a follow-up CL, you ...
4 years, 3 months ago (2016-09-19 16:40:22 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 16:49:16 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/a5b37f6b916f1a35d3fbb3f0b41e9e4b4d26...

Powered by Google App Engine
This is Rietveld 408576698