Disable VIDEO_HOLE on Android

Disable VIDEO_HOLE on Android

Android WebView and Chromecast both moved off of VIDEO_HOLE in m52.
Turning it off for Android build now. Removing deadcode in follow up CL.

Committed: https://crrev.com/fa8868418ffe9da48614de5bff07b72f97760f51
Cr-Commit-Position: refs/heads/master@{#419625}

[boliu, 2016-09-19 21:27:08]

The CQ bit was checked by boliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 21:27:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2016-09-19 21:28:09]

The CQ bit was unchecked by boliu@chromium.org

[boliu, 2016-09-19 21:30:31]

The CQ bit was checked by boliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 21:30:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 21:40:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 21:40:08]

Dry run: This issue passed the CQ dry run.

[boliu, 2016-09-19 21:41:54]

boliu@chromium.org changed reviewers:
+ dpranke@chromium.org

[boliu, 2016-09-19 21:41:55]

+dpranke for owners

all the android bots skipped compile altogether, so I think this is also a bug
in analyze. is it known?

I think I'll upload a patch set with a dummy change to make sure android still
builds..

[boliu, 2016-09-19 21:43:49]

Description was changed from

==========
Disable VIDEO_HOLE on Android

Android WebView and Chromecast both moved off of VIDEO_HOLE in m52.
Turning it off for Android build now. Removing deadcode in follow up CL.
==========

to

==========
Disable VIDEO_HOLE on Android

Android WebView and Chromecast both moved off of VIDEO_HOLE in m52.
Turning it off for Android build now. Removing deadcode in follow up CL.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[boliu, 2016-09-19 21:44:13]

The CQ bit was checked by boliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 21:44:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2016-09-19 22:55:52]

Description was changed from

==========
Disable VIDEO_HOLE on Android

Android WebView and Chromecast both moved off of VIDEO_HOLE in m52.
Turning it off for Android build now. Removing deadcode in follow up CL.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Disable VIDEO_HOLE on Android

Android WebView and Chromecast both moved off of VIDEO_HOLE in m52.
Turning it off for Android build now. Removing deadcode in follow up CL.
==========

[boliu, 2016-09-19 23:00:10]

All android bots passed compile on PS3. PTAL

[Dirk Pranke, 2016-09-19 23:10:38]

On 2016/09/19 23:00:10, boliu wrote:
> All android bots passed compile on PS3. PTAL

Ah, that's a bug in analyze, and no, it wasn't known. Thanks for pointing me at
it!

[Dirk Pranke, 2016-09-19 23:13:12]

//build changes lgtm, though you don't really need to modify common.gypi.

[boliu, 2016-09-19 23:14:50]

On 2016/09/19 23:13:12, Dirk Pranke wrote:
> //build changes lgtm, though you don't really need to modify common.gypi.

Doesn't hurt either, right?

[boliu, 2016-09-19 23:24:31]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2016-09-19 23:25:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-09-19 23:46:05]

On 2016/09/19 23:14:50, boliu wrote:
> On 2016/09/19 23:13:12, Dirk Pranke wrote:
> > //build changes lgtm, though you don't really need to modify common.gypi.
> 
> Doesn't hurt either, right?

correct, as long as this lands before the CL I'll post to delete most of it ;).

[commit-bot: I haz the power, 2016-09-20 01:24:23]

Description was changed from

==========
Disable VIDEO_HOLE on Android

Android WebView and Chromecast both moved off of VIDEO_HOLE in m52.
Turning it off for Android build now. Removing deadcode in follow up CL.
==========

to

==========
Disable VIDEO_HOLE on Android

Android WebView and Chromecast both moved off of VIDEO_HOLE in m52.
Turning it off for Android build now. Removing deadcode in follow up CL.
==========

[commit-bot: I haz the power, 2016-09-20 01:24:24]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-20 01:26:59]

Description was changed from

==========
Disable VIDEO_HOLE on Android

Android WebView and Chromecast both moved off of VIDEO_HOLE in m52.
Turning it off for Android build now. Removing deadcode in follow up CL.
==========

to

==========
Disable VIDEO_HOLE on Android

Android WebView and Chromecast both moved off of VIDEO_HOLE in m52.
Turning it off for Android build now. Removing deadcode in follow up CL.

Committed: https://crrev.com/fa8868418ffe9da48614de5bff07b72f97760f51
Cr-Commit-Position: refs/heads/master@{#419625}
==========

[commit-bot: I haz the power, 2016-09-20 01:27:00]

Patchset 5 (id:??) landed as
https://crrev.com/fa8868418ffe9da48614de5bff07b72f97760f51
Cr-Commit-Position: refs/heads/master@{#419625}