[SimpleCache] Track some SimpleCache size stats on initialization

[SimpleCache] Track some SimpleCache size stats on initialization

Once the SimpleCache has initialized, record its size, its max size, how full
it is, and how many entries it has. This gives us insight into the utilization
of caches.

BUG=617620
Committed: https://crrev.com/9e25895414b4a327440262769ca8cd785fdbcddb
Cr-Commit-Position: refs/heads/master@{#420941}

[jkarlin, 2016-09-19 18:37:16]

Description was changed from

==========
[SimpleCache] Track some cache size stats on initialization

Once the SimpleCache has initialized, record its size, its max size, how full
it is, and how many entries it has. This gives us insight into the utilization
of caches.

BUG=617620
==========

to

==========
[SimpleCache] Track some SimpleCache size stats on initialization

Once the SimpleCache has initialized, record its size, its max size, how full
it is, and how many entries it has. This gives us insight into the utilization
of caches.

BUG=617620
==========

[jkarlin, 2016-09-19 18:43:02]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[jkarlin, 2016-09-19 18:43:23]

jkarlin@chromium.org changed reviewers:
+ gavinp@chromium.org

[jkarlin, 2016-09-19 18:43:24]

gavinp@ PTAL at everything, thanks!

[commit-bot: I haz the power, 2016-09-19 18:43:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 19:49:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 19:49:05]

Dry run: This issue passed the CQ dry run.

[jkarlin, 2016-09-22 15:24:50]

gavinp@ PTAL, thank you.

[jkarlin, 2016-09-23 14:19:56]

gavinp@ Ping!

[gavinp, 2016-09-23 15:22:35]

lgtm

[jkarlin, 2016-09-23 15:26:01]

jkarlin@chromium.org changed reviewers:
+ rkaplow@chromium.org

[jkarlin, 2016-09-23 15:26:02]

rkaplow@ PTAL, thanks!

[rkaplow, 2016-09-26 14:00:42]

lgtm

https://codereview.chromium.org/2355493003/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2355493003/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:56544: +<histogram
name="SimpleCache.IndexNumEntriesOnInit">
shuold still have a unit, like "entries" or something

[jkarlin, 2016-09-26 15:42:53]

Thanks!

https://codereview.chromium.org/2355493003/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2355493003/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:56544: +<histogram
name="SimpleCache.IndexNumEntriesOnInit">
On 2016/09/26 14:00:42, rkaplow wrote:
> shuold still have a unit, like "entries" or something

Done.

[jkarlin, 2016-09-26 15:42:58]

The CQ bit was checked by jkarlin@chromium.org

[jkarlin, 2016-09-26 15:42:58]

The patchset sent to the CQ was uploaded after l-g-t-m from gavinp@chromium.org,
rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2355493003/#ps60001
(title: "Address comments from PS2")

[commit-bot: I haz the power, 2016-09-26 15:43:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2016-09-26 16:52:39]

The CQ bit was unchecked by jkarlin@chromium.org

[jkarlin, 2016-09-26 16:54:04]

The CQ bit was checked by jkarlin@chromium.org

[jkarlin, 2016-09-26 16:54:04]

The patchset sent to the CQ was uploaded after l-g-t-m from gavinp@chromium.org,
rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2355493003/#ps80001
(title: "Address comments from PS2")

[jkarlin, 2016-09-26 16:54:25]

Patchset #4 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-09-26 16:54:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 18:36:13]

Description was changed from

==========
[SimpleCache] Track some SimpleCache size stats on initialization

Once the SimpleCache has initialized, record its size, its max size, how full
it is, and how many entries it has. This gives us insight into the utilization
of caches.

BUG=617620
==========

to

==========
[SimpleCache] Track some SimpleCache size stats on initialization

Once the SimpleCache has initialized, record its size, its max size, how full
it is, and how many entries it has. This gives us insight into the utilization
of caches.

BUG=617620
==========

[commit-bot: I haz the power, 2016-09-26 18:36:14]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-09-26 18:39:18]

Description was changed from

==========
[SimpleCache] Track some SimpleCache size stats on initialization

Once the SimpleCache has initialized, record its size, its max size, how full
it is, and how many entries it has. This gives us insight into the utilization
of caches.

BUG=617620
==========

to

==========
[SimpleCache] Track some SimpleCache size stats on initialization

Once the SimpleCache has initialized, record its size, its max size, how full
it is, and how many entries it has. This gives us insight into the utilization
of caches.

BUG=617620

Committed: https://crrev.com/9e25895414b4a327440262769ca8cd785fdbcddb
Cr-Commit-Position: refs/heads/master@{#420941}
==========

[commit-bot: I haz the power, 2016-09-26 18:39:19]

Patchset 4 (id:??) landed as
https://crrev.com/9e25895414b4a327440262769ca8cd785fdbcddb
Cr-Commit-Position: refs/heads/master@{#420941}