Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2355493002: Move vulkan spir-v compile call to GrVkUtil (Closed)

Created:
4 years, 3 months ago by egdaniel
Modified:
4 years, 3 months ago
Reviewers:
ethannicholas
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move vulkan spir-v compile call to GrVkUtil BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355493002 Committed: https://skia.googlesource.com/skia/+/88987d83d70654042f7c34f1a92bfd2b8edbe482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -100 lines) Patch
M src/gpu/vk/GrVkPipelineStateBuilder.cpp View 3 chunks +1 line, -99 lines 0 comments Download
M src/gpu/vk/GrVkUtil.h View 2 chunks +8 lines, -1 line 0 comments Download
M src/gpu/vk/GrVkUtil.cpp View 2 chunks +108 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
egdaniel
In a future change I will need the ability to compile SPIR-V outside of our ...
4 years, 3 months ago (2016-09-19 15:30:34 UTC) #3
ethannicholas
On 2016/09/19 15:30:34, egdaniel wrote: > In a future change I will need the ability ...
4 years, 3 months ago (2016-09-19 16:57:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355493002/1
4 years, 3 months ago (2016-09-19 16:57:45 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 17:17:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/88987d83d70654042f7c34f1a92bfd2b8edbe482

Powered by Google App Engine
This is Rietveld 408576698