src/effects/SkXfermodeImageFilter.cpp - Issue 2355483002: abstract name of clipping ops, to transtion to a more restricted set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkXfermodeImageFilter.cpp

Issue 2355483002: abstract name of clipping ops, to transtion to a more restricted set (Closed)

Patch Set: remove setClipRegion entirely Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkXfermodeImageFilter.cpp

diff --git a/src/effects/SkXfermodeImageFilter.cpp b/src/effects/SkXfermodeImageFilter.cpp

index 8721dd756eee0ffbf0bbacc28bc66970db6f1d61..c82482d9ab8285ac2e43b75531f6599fae653762 100644

--- a/src/effects/SkXfermodeImageFilter.cpp

+++ b/src/effects/SkXfermodeImageFilter.cpp

@@ -125,7 +125,7 @@ sk_sp<SkSpecialImage> SkXfermodeImageFilter::onFilterImage(SkSpecialImage* sourc

&paint);

}

- canvas->clipRect(SkRect::Make(foregroundBounds), SkRegion::kDifference_Op);

+ canvas->clipRect(SkRect::Make(foregroundBounds), SkCanvas::kDifference_Op);

paint.setColor(SK_ColorTRANSPARENT);

canvas->drawPaint(paint);