Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Side by Side Diff: src/core/SkRecorder.cpp

Issue 2355483002: abstract name of clipping ops, to transtion to a more restricted set (Closed)
Patch Set: no need for ifdef for globals Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/core/SkRecorder.h ('k') | src/effects/SkXfermodeImageFilter.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2014 Google Inc. 2 * Copyright 2014 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkBigPicture.h" 8 #include "SkBigPicture.h"
9 #include "SkCanvasPriv.h" 9 #include "SkCanvasPriv.h"
10 #include "SkImage.h" 10 #include "SkImage.h"
(...skipping 384 matching lines...) Expand 10 before | Expand all | Expand 10 after
395 void SkRecorder::didTranslate(SkScalar dx, SkScalar dy) { 395 void SkRecorder::didTranslate(SkScalar dx, SkScalar dy) {
396 APPEND(Translate, dx, dy); 396 APPEND(Translate, dx, dy);
397 } 397 }
398 398
399 void SkRecorder::didTranslateZ(SkScalar z) { 399 void SkRecorder::didTranslateZ(SkScalar z) {
400 #ifdef SK_EXPERIMENTAL_SHADOWING 400 #ifdef SK_EXPERIMENTAL_SHADOWING
401 APPEND(TranslateZ, z); 401 APPEND(TranslateZ, z);
402 #endif 402 #endif
403 } 403 }
404 404
405 void SkRecorder::onClipRect(const SkRect& rect, SkRegion::Op op, ClipEdgeStyle e dgeStyle) { 405 void SkRecorder::onClipRect(const SkRect& rect, ClipOp op, ClipEdgeStyle edgeSty le) {
406 INHERITED(onClipRect, rect, op, edgeStyle); 406 INHERITED(onClipRect, rect, op, edgeStyle);
407 SkRecords::RegionOpAndAA opAA(op, kSoft_ClipEdgeStyle == edgeStyle); 407 SkRecords::ClipOpAndAA opAA(op, kSoft_ClipEdgeStyle == edgeStyle);
408 APPEND(ClipRect, this->devBounds(), rect, opAA); 408 APPEND(ClipRect, this->devBounds(), rect, opAA);
409 } 409 }
410 410
411 void SkRecorder::onClipRRect(const SkRRect& rrect, SkRegion::Op op, ClipEdgeStyl e edgeStyle) { 411 void SkRecorder::onClipRRect(const SkRRect& rrect, ClipOp op, ClipEdgeStyle edge Style) {
412 INHERITED(onClipRRect, rrect, op, edgeStyle); 412 INHERITED(onClipRRect, rrect, op, edgeStyle);
413 SkRecords::RegionOpAndAA opAA(op, kSoft_ClipEdgeStyle == edgeStyle); 413 SkRecords::ClipOpAndAA opAA(op, kSoft_ClipEdgeStyle == edgeStyle);
414 APPEND(ClipRRect, this->devBounds(), rrect, opAA); 414 APPEND(ClipRRect, this->devBounds(), rrect, opAA);
415 } 415 }
416 416
417 void SkRecorder::onClipPath(const SkPath& path, SkRegion::Op op, ClipEdgeStyle e dgeStyle) { 417 void SkRecorder::onClipPath(const SkPath& path, ClipOp op, ClipEdgeStyle edgeSty le) {
418 INHERITED(onClipPath, path, op, edgeStyle); 418 INHERITED(onClipPath, path, op, edgeStyle);
419 SkRecords::RegionOpAndAA opAA(op, kSoft_ClipEdgeStyle == edgeStyle); 419 SkRecords::ClipOpAndAA opAA(op, kSoft_ClipEdgeStyle == edgeStyle);
420 APPEND(ClipPath, this->devBounds(), path, opAA); 420 APPEND(ClipPath, this->devBounds(), path, opAA);
421 } 421 }
422 422
423 void SkRecorder::onClipRegion(const SkRegion& deviceRgn, SkRegion::Op op) { 423 void SkRecorder::onClipRegion(const SkRegion& deviceRgn, ClipOp op) {
424 INHERITED(onClipRegion, deviceRgn, op); 424 INHERITED(onClipRegion, deviceRgn, op);
425 APPEND(ClipRegion, this->devBounds(), deviceRgn, op); 425 APPEND(ClipRegion, this->devBounds(), deviceRgn, op);
426 } 426 }
427 427
428 sk_sp<SkSurface> SkRecorder::onNewSurface(const SkImageInfo&, const SkSurfacePro ps&) { 428 sk_sp<SkSurface> SkRecorder::onNewSurface(const SkImageInfo&, const SkSurfacePro ps&) {
429 return nullptr; 429 return nullptr;
430 } 430 }
OLDNEW
« no previous file with comments | « src/core/SkRecorder.h ('k') | src/effects/SkXfermodeImageFilter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698