Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2339)

Unified Diff: chrome/browser/prerender/prerender_contents.cc

Issue 2355453002: [NoStatePrefetch] Support only GET and HEAD (Closed)
Patch Set: review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_contents.h ('k') | chrome/browser/prerender/prerender_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_contents.cc
diff --git a/chrome/browser/prerender/prerender_contents.cc b/chrome/browser/prerender/prerender_contents.cc
index 5d83c15b0cd812dbd37d0f4016e3188cd0690335..890008ada304554b0708e70fb887261be35f8afd 100644
--- a/chrome/browser/prerender/prerender_contents.cc
+++ b/chrome/browser/prerender/prerender_contents.cc
@@ -58,6 +58,16 @@ namespace prerender {
namespace {
+// Valid HTTP methods for both prefetch and prerendering.
+const char* const kValidHttpMethods[] = {
+ "GET", "HEAD",
+};
+
+// Additional valid HTTP methods for prerendering.
+const char* const kValidHttpMethodsForPrerendering[] = {
+ "OPTIONS", "POST", "TRACE",
+};
+
void ResumeThrottles(
std::vector<base::WeakPtr<PrerenderResourceThrottle> > throttles) {
for (size_t i = 0; i < throttles.size(); i++) {
@@ -223,6 +233,27 @@ void PrerenderContents::SetPrerenderMode(PrerenderMode mode) {
prerender_mode_ = mode;
}
+bool PrerenderContents::IsValidHttpMethod(const std::string& method) {
+ DCHECK_NE(prerender_mode(), NO_PRERENDER);
+ // |method| has been canonicalized to upper case at this point so we can just
+ // compare them.
+ DCHECK_EQ(method, base::ToUpperASCII(method));
+ for (const auto& valid_method : kValidHttpMethods) {
+ if (method == valid_method)
+ return true;
+ }
+
+ if (prerender_mode() == PREFETCH_ONLY)
+ return false;
+
+ for (const auto& valid_method : kValidHttpMethodsForPrerendering) {
+ if (method == valid_method)
+ return true;
+ }
+
+ return false;
+}
+
// static
PrerenderContents::Factory* PrerenderContents::CreateFactory() {
return new PrerenderContentsFactoryImpl();
« no previous file with comments | « chrome/browser/prerender/prerender_contents.h ('k') | chrome/browser/prerender/prerender_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698