Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: chrome/browser/prerender/prerender_unittest.cc

Issue 2355453002: [NoStatePrefetch] Support only GET and HEAD (Closed)
Patch Set: Review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_unittest.cc
diff --git a/chrome/browser/prerender/prerender_unittest.cc b/chrome/browser/prerender/prerender_unittest.cc
index 42ed22c0b15a24d9e2f5e984dde5304cd10d0fa6..607f49b8872fd2906f7ec3a69a254348b0b39106 100644
--- a/chrome/browser/prerender/prerender_unittest.cc
+++ b/chrome/browser/prerender/prerender_unittest.cc
@@ -1730,4 +1730,26 @@ TEST_F(PrerenderTest, PrerenderContentsForInstantSearch) {
EXPECT_FALSE(prerender_handle->IsPrerendering());
}
+TEST_F(PrerenderTest, PrerenderContentsIsValidHttpMethod) {
+ DummyPrerenderContents* prerender_contents =
+ prerender_manager()->CreateNextPrerenderContents(
+ GURL("my://dummy.url"), FINAL_STATUS_MANAGER_SHUTDOWN);
+
+ prerender_contents->SetPrerenderMode(FULL_PRERENDER);
+ EXPECT_TRUE(prerender_contents->IsValidHttpMethod("GET"));
+ EXPECT_TRUE(prerender_contents->IsValidHttpMethod("HEAD"));
+ EXPECT_TRUE(prerender_contents->IsValidHttpMethod("OPTIONS"));
+ EXPECT_TRUE(prerender_contents->IsValidHttpMethod("POST"));
+ EXPECT_TRUE(prerender_contents->IsValidHttpMethod("TRACE"));
+ EXPECT_FALSE(prerender_contents->IsValidHttpMethod("WHATEVER"));
+
+ prerender_contents->SetPrerenderMode(PREFETCH_ONLY);
+ EXPECT_TRUE(prerender_contents->IsValidHttpMethod("GET"));
+ EXPECT_TRUE(prerender_contents->IsValidHttpMethod("HEAD"));
+ EXPECT_FALSE(prerender_contents->IsValidHttpMethod("OPTIONS"));
+ EXPECT_FALSE(prerender_contents->IsValidHttpMethod("POST"));
+ EXPECT_FALSE(prerender_contents->IsValidHttpMethod("TRACE"));
+ EXPECT_FALSE(prerender_contents->IsValidHttpMethod("WHATEVER"));
+}
+
} // namespace prerender

Powered by Google App Engine
This is Rietveld 408576698