[NoStatePrefetch] Support only GET and HEAD

chrome/browser/prerender/prerender_contents.cc

Index: chrome/browser/prerender/prerender_contents.cc
diff --git a/chrome/browser/prerender/prerender_contents.cc b/chrome/browser/prerender/prerender_contents.cc
index 5e4b3adde081cf5946bff597331e285539392fad..64339e3a1b6295f1931a47d89c6a41c5f6c0bc2e 100644
--- a/chrome/browser/prerender/prerender_contents.cc
+++ b/chrome/browser/prerender/prerender_contents.cc
@@ -58,6 +58,16 @@ namespace prerender {
 
 namespace {
 
+// Valid HTTP methods for both prefetch and prerendering.
+const char* const kValidHttpMethods[] = {
+    "GET", "HEAD",
+};
+
+// Additional valid HTTP methods for prerendering.
+const char* const kValidHttpMethodsForPrerendering[] = {
+    "OPTIONS", "POST", "TRACE",
+};
+
 void ResumeThrottles(
     std::vector<base::WeakPtr<PrerenderResourceThrottle> > throttles) {
   for (size_t i = 0; i < throttles.size(); i++) {
@@ -223,6 +233,27 @@ void PrerenderContents::SetPrerenderMode(PrerenderMode mode) {
   prerender_mode_ = mode;
 }
 
+bool PrerenderContents::IsValidHttpMethod(const std::string& method) {
+  DCHECK_NE(prerender_mode(), NO_PRERENDER);
+  // method has been canonicalized to upper case at this point so we can just

[pasko, 2016/09/21 17:59:53]

nit: s/method/|method|/

[droger, 2016/09/22 08:42:01]

Done.

+  // compare them.
+  DCHECK_EQ(method, base::ToUpperASCII(method));
+  for (const char* const valid_method : kValidHttpMethods) {
+    if (method == valid_method)
+      return true;
+  }
+
+  if (prerender_mode() == PREFETCH_ONLY)
+    return false;
+
+  for (const char* const valid_method : kValidHttpMethodsForPrerendering) {

[pasko, 2016/09/21 17:59:53]

nit: do we really need to be so explicit here about const?

perhaps auto* valid_method?

[droger, 2016/09/22 08:42:01]

Done.

+    if (method == valid_method)
+      return true;
+  }
+
+  return false;
+}
+
 // static
 PrerenderContents::Factory* PrerenderContents::CreateFactory() {
   return new PrerenderContentsFactoryImpl();