Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3341)

Unified Diff: chrome/browser/prerender/prerender_resource_throttle.cc

Issue 2355453002: [NoStatePrefetch] Support only GET and HEAD (Closed)
Patch Set: format Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_resource_throttle.cc
diff --git a/chrome/browser/prerender/prerender_resource_throttle.cc b/chrome/browser/prerender/prerender_resource_throttle.cc
index 200e2865557792db5a3c5c694c05a6bfac76474b..0f7ca5225376443b35c04edd3ba8cd2921ee9f9a 100644
--- a/chrome/browser/prerender/prerender_resource_throttle.cc
+++ b/chrome/browser/prerender/prerender_resource_throttle.cc
@@ -121,7 +121,7 @@ void PrerenderResourceThrottle::WillStartRequestOnUI(
if (prerender_contents) {
// Abort any prerenders that spawn requests that use unsupported HTTP
// methods or schemes.
- if (!PrerenderManager::IsValidHttpMethod(method)) {
+ if (!prerender_contents->IsValidHttpMethod(method)) {
mmenke 2016/09/20 13:31:18 Would it make more sense just to cancel the indivi
droger 2016/09/20 15:07:27 I think you are right indeed, we could cancel the
droger 2016/09/21 09:57:48 Done, although the scenario where a prefetch subre
mmenke 2016/09/21 16:56:20 Good point, though I suppose extensions and Chrome
prerender_contents->Destroy(FINAL_STATUS_INVALID_HTTP_METHOD);
cancel = true;
} else if (!PrerenderManager::DoesSubresourceURLHaveValidScheme(url)) {

Powered by Google App Engine
This is Rietveld 408576698