Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: src/IceAssemblerMIPS32.cpp

Issue 2355413008: Subzero, MIPS32: Fix floating point comparison crosstest (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceAssemblerMIPS32.cpp
diff --git a/src/IceAssemblerMIPS32.cpp b/src/IceAssemblerMIPS32.cpp
index ac2d10b8b6bfe7874c88c7ea51b7d76f7923b44b..2f3c7efb0222391c1cf0e8255920b321b0d0ce7a 100644
--- a/src/IceAssemblerMIPS32.cpp
+++ b/src/IceAssemblerMIPS32.cpp
@@ -528,10 +528,12 @@ void AssemblerMIPS32::lw(const Operand *OpRt, const Operand *OpBase,
case IceType_i8: {
static constexpr IValueT Opcode = 0x80000000;
emitRtRsImm16(Opcode, OpRt, OpBase, Offset, "lb");
+ break;
}
case IceType_i16: {
static constexpr IValueT Opcode = 0x84000000;
emitRtRsImm16(Opcode, OpRt, OpBase, Offset, "lh");
+ break;
}
case IceType_i32: {
static constexpr IValueT Opcode = 0x8C000000;
@@ -541,6 +543,7 @@ void AssemblerMIPS32::lw(const Operand *OpRt, const Operand *OpBase,
case IceType_f32: {
static constexpr IValueT Opcode = 0xC4000000;
emitFtRsImm16(Opcode, OpRt, OpBase, Offset, "lwc1");
+ break;
}
case IceType_f64: {
static constexpr IValueT Opcode = 0xD4000000;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698