Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2355413008: Subzero, MIPS32: Fix floating point comparison crosstest (Closed)

Created:
4 years, 3 months ago by obucinac
Modified:
4 years, 3 months ago
CC:
native-client-reviews_googlegroups.com, rich_fuhler_imgtec.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero, MIPS32: Fix floating point comparison crosstest Floating point comparison crosstest was failing in filetype=obj mode because of missing breaks in load encoding functions. With this patch, crosstest generator, with vector tests disabled, for parameters --filetype=obj --include=test_fcmp,mips32,native,Om1,base returns TotalTests=123904 Passes=123904 Failures=0 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=6ee373fc6c638c7931c31727db8d4463646df1de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/IceAssemblerMIPS32.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
obucinac
4 years, 3 months ago (2016-09-23 04:14:48 UTC) #3
Jim Stichnoth
lgtm
4 years, 3 months ago (2016-09-23 05:01:47 UTC) #6
Jim Stichnoth
4 years, 3 months ago (2016-09-23 05:01:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6ee373fc6c638c7931c31727db8d4463646df1de (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698