Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 2355413005: Issue 27375. Use ContextBuilder to find analysis options file in analyzer_cli. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M pkg/analyzer_cli/lib/src/driver.dart View 1 chunk +2 lines, -6 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 3 months ago (2016-09-22 21:42:54 UTC) #1
Brian Wilkerson
https://codereview.chromium.org/2355413005/diff/1/pkg/analyzer_cli/lib/src/driver.dart File pkg/analyzer_cli/lib/src/driver.dart (right): https://codereview.chromium.org/2355413005/diff/1/pkg/analyzer_cli/lib/src/driver.dart#newcode748 pkg/analyzer_cli/lib/src/driver.dart:748: .getOptionsFile(options.sourceFiles.first); I'm not sure how this works. The method ...
4 years, 3 months ago (2016-09-22 22:01:20 UTC) #2
Brian Wilkerson
After off-line discussion, lgtm
4 years, 3 months ago (2016-09-22 22:09:27 UTC) #3
scheglov
4 years, 3 months ago (2016-09-22 22:11:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
75a4f968beb01b2023500e0e6a09c605d474064f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698